Skip to content

[FSSDK-9570] add explicit entry point for node, browser and react_native #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2024
Merged

[FSSDK-9570] add explicit entry point for node, browser and react_native #905

merged 1 commit into from
Feb 26, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • add explicit entry point for node, browser and react_native

Test plan

  • tested manually with logging that the correct bundle is loaded

Issues

  • FSSDK-9570

@raju-opti raju-opti requested a review from a team as a code owner February 23, 2024 17:38
@coveralls
Copy link

Coverage Status

coverage: 90.373%. remained the same
when pulling 680bfb4 on raju/entrypoint
into e938e3c on master.

mikechu-optimizely
mikechu-optimizely approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 311e7e2 into master Feb 26, 2024
@raju-opti raju-opti deleted the raju/entrypoint branch February 26, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely