Skip to content

[FSSDK-8503]: Update Github Issue Templates. #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 1, 2023
Merged

[FSSDK-8503]: Update Github Issue Templates. #840

merged 5 commits into from
Aug 1, 2023

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Jul 31, 2023 •
edited by mikechu-optimizely
Loading

Summary

  • Update Github Issue Templates

Issues

Preview

@coveralls
Copy link

coveralls commented Jul 31, 2023 •
edited
Loading

Coverage Status

coverage: 90.521%. remained the same when pulling ff970a4 on yasir/FSSDK-8503 into f75f1f9 on master.

mikechu-optimizely
mikechu-optimizely approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 marked this pull request as ready for review July 31, 2023 22:30
@yasirfolio3 yasirfolio3 requested a review from a team as a code owner July 31, 2023 22:30
mikechu-optimizely
mikechu-optimizely requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

mikechu-optimizely
mikechu-optimizely approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some last suggestions for the taking or leaving.

@mikechu-optimizely mikechu-optimizely changed the title FSSDK-8503: Update Github Issue Templates. [FSSDK-8503]: Update Github Issue Templates. Aug 1, 2023
jaeopt
jaeopt approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 merged commit b83a884 into master Aug 1, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-8503 branch August 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@yasirfolio3 yasirfolio3

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yasirfolio3 @coveralls @jaeopt @mikechu-optimizely