-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Add ODP LRU Cache #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Originally created React Native specific variations for AsyncStorage consideration, but since we're only concerned with an in-memory LRU Cache, will remove LRU Cache code specific to React Native. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small changes suggested.
packages/optimizely-sdk/lib/core/odp/lru_cache/LRUCacheElement.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
A generic LRU cache to support efficient caching of the ODP segments results.
Test plan
Added new unit tests files for Client/Server/React Native implementations.
Issues
OASIS-8410