Skip to content

chore: prepare for release 4.9.0 #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 15, 2022
Merged

chore: prepare for release 4.9.0 #731

merged 5 commits into from
Jan 15, 2022

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Jan 6, 2022 •
edited by zashraf1985
Loading

Summary

  • Prepare for release 4.9.0

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner January 6, 2022 07:30
@coveralls
Copy link

coveralls commented Jan 6, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 97.184% when pulling 3f631f6 on yasir/prepare-4.9.0 into a638aae on master.

jaeopt
jaeopt requested changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in CHANGELOG

packages/optimizely-sdk/CHANGELOG.MD Outdated
## [4.9.0] - January 6, 2022

### New Features
* Add a set of new APIs for overriding and managing user-level flag, experiment and delivery rule decisions. These methods can be used for QA and automated testing purposes. They are an extension of the OptimizelyUserContext interface [#727](https://github.com/optimizely/javascript-sdk/pull/727), [#729](https://github.com/optimizely/javascript-sdk/pull/729), [#730](https://github.com/optimizely/javascript-sdk/pull/730)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [#705] the first PR to the list. Also, fix format - the opening parenthesis is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, since 705 was part of the 4.8.0 release, i removed it from this PR. Have now removed the commit containing that change, thanks for confirming 👍

@yasirfolio3 yasirfolio3 requested a review from jaeopt January 7, 2022 10:35
jaeopt
jaeopt approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit 2e0623c into master Jan 15, 2022
@zashraf1985 zashraf1985 deleted the yasir/prepare-4.9.0 branch January 15, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@yasirfolio3 yasirfolio3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasirfolio3 @coveralls @jaeopt @zashraf1985 @ozayr-zaviar