feat: Added support for sdkKey and environmentKey in OptimizelyConfig #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
force-pushed
the
pnguen/add-sdkkey-and-envkey-to-datafile
branch
from
2e77149 to
0777a6b
Compare
zashraf1985
approved these changes
Jun 17, 2021
| private datafile: string; | ||
|
|
||
| constructor(configObj: ProjectConfig, datafile: string) { | ||
| this.experimentsMap = OptimizelyConfig.getExperimentsMap(configObj); | ||
| this.featuresMap = OptimizelyConfig.getFeaturesMap(configObj, this.experimentsMap); | ||
| this.revision = configObj.revision; | ||
| this.datafile = datafile; | ||
|
|
||
| if (configObj.sdkKey) { |
There was a problem hiding this comment.
Can't we combine both conditions? e.g.
if (configObj.sdkKey && configObj.enviornmentKey) {
}
it's not possible any of the key is present and the other one is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sdkKeyandenvironmentKeyin datafile, ProjectConfig, and OptimizelyConfig.Test plan
Existing unit tests + new tests + FSC