Skip to content

Added Optimizely Config in Typescript #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2020
Merged

Added Optimizely Config in Typescript #390

merged 5 commits into from
Jan 28, 2020

Conversation

fayyazarshad
Copy link
Contributor

@fayyazarshad fayyazarshad commented Jan 28, 2020 •
edited by msohailhussain
Loading

Summary

Added Optimizely Config in Typescript

TestPlan

Don't have any specific testplan but react sdk should work for OptimizelyConfig

@fayyazarshad fayyazarshad self-assigned this Jan 28, 2020
@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.42% when pulling 7375b99 on fayyaz/add-optimizely-config-typescript into 6fd2901 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.42% when pulling 072c3c4 on fayyaz/add-optimizely-config-typescript into 6fd2901 on master.

msohailhussain
msohailhussain reviewed Jan 28, 2020
View reviewed changes
msohailhussain
msohailhussain reviewed Jan 28, 2020
View reviewed changes
@msohailhussain msohailhussain marked this pull request as ready for review January 28, 2020 19:31
@msohailhussain msohailhussain requested a review from a team as a code owner January 28, 2020 19:31
mjc1283
mjc1283 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, then LGTM. getOptimizelyConfig can also return null. Please update that before merging.

@msohailhussain @mjc1283
Update packages/optimizely-sdk/lib/index.d.ts
7375b99 
Co-Authored-By: Matt Carroll <mjc1283@users.noreply.github.com>
msohailhussain
msohailhussain approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 8e906b7 into master Jan 28, 2020
@jaeopt jaeopt deleted the fayyaz/add-optimizely-config-typescript branch January 28, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@fayyazarshad fayyazarshad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fayyazarshad @coveralls @mjc1283 @msohailhussain @jaeopt