Skip to content

Jenkins CI Test Script #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2016
Merged

Jenkins CI Test Script #23

merged 2 commits into from
Nov 17, 2016

Conversation

wangjoshuah
Copy link
Contributor

Write a test script for jenkins ci that mimics travis tests
runs npm install and npm test for the following node versions

  • node 5
  • node 0.10
  • node

mikeproeng37
mikeproeng37 approved these changes Nov 17, 2016
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

@mikeproeng37 mikeproeng37 merged commit fafe40c into devel Nov 17, 2016
@wangjoshuah wangjoshuah deleted the josh.wang/jenkins/start_devel_test_script branch November 17, 2016 18:12
@wangjoshuah wangjoshuah restored the josh.wang/jenkins/start_devel_test_script branch March 15, 2017 18:39
mjc1283 added a commit that referenced this pull request Apr 22, 2019
@mjc1283
fix (project config manager & Optimizely): Always fulfill onReady Pro…
d95aee5 
…mise with a result object, instead of sometimes rejecting (#23)

Summary:

When documenting datafile management, I realized the rationale behind the behavior of the promise returned from Optimizely onReady was inconsistent. It would sometimes fulfill even if the instance was still not ready to be used. Also, I thought it would be better to always fulfill because we attempt to never throw errors, and rejected promises are akin to thrown errors.

Before this change, the promise would fulfill either when a valid project config was obtained prior to the timeout, or when the timeout expired, and reject in other cases.

With this change, the promise always fulfills with a result object of the form { success: boolean, reason?: string }. When success is true, the instance has a valid project config and is ready to use. When success is false, the instance failed to become ready, and reason explains why.

Test plan:

Updated unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees

@mikeproeng37 mikeproeng37

@haleybash-optimizely haleybash-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangjoshuah @mikeproeng37 @haleybash-optimizely