chore(ci): Ensure Travis unit tests also run on release branches. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
requested review from
tylerbrandt and
spencerwilson-optimizely
|
Can we just run on all branches? |
|
Were you thinking about running these when we open up PRs against feature branches? My only concern is that could exhaust our resource alloc on Travis. With this we will at least run Travis unit tests whenever there are PRs open against those branches. |
tylerbrandt
approved these changes
Sep 21, 2018
aliabbasrizvi
approved these changes
Sep 27, 2018
spencerwilson-optimizely
approved these changes
Oct 1, 2018
mikeproeng37
added a commit
that referenced
this pull request
Nov 15, 2018
mikeproeng37
added a commit
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release branches need to have unit tests run on them given that we will soon be in a state (3.x release) where we can't always fast-forward these branches to the latest master.