Skip to content

Commit fee016d

Browse files
committed
finalized the code
1 parent b89eed7 commit fee016d

File tree

6 files changed

+1487
-122
lines changed

6 files changed

+1487
-122
lines changed

packages/optimizely-sdk/karma.base.conf.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports = {
2020
basePath: '',
2121

2222
//plugins
23-
plugins: ['karma-mocha', 'karma-webpack', require('karma-browserstack-launcher')],
23+
plugins: ['karma-mocha', 'karma-webpack', require('karma-browserstack-launcher'), require('karma-babel-preprocessor')],
2424

2525
webpack: {
2626
mode: 'production',
@@ -102,6 +102,12 @@ module.exports = {
102102
'./lib/**/*tests.js': ['webpack'],
103103
},
104104

105+
babelPreprocessor: {
106+
options: {
107+
presets: ['@babel/preset-env'],
108+
},
109+
},
110+
105111
// test results reporter to use
106112
// possible values: 'dots', 'progress'
107113
// available reporters: https://npmjs.org/browse/keyword/karma-reporter

packages/optimizely-sdk/lib/index.browser.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@ import defaultErrorHandler from './plugins/error_handler';
2525
import defaultEventDispatcher from './plugins/event_dispatcher/index.browser';
2626
import eventProcessorConfigValidator from './utils/event_processor_config_validator';
2727

28-
var logger = sdkLogging.getLogger();
28+
const logger = sdkLogging.getLogger();
2929
sdkLogging.setLogHandler(loggerPlugin.createLogger());
3030
sdkLogging.setLogLevel(sdkLogging.LogLevel.INFO);
3131

32-
var MODULE_NAME = 'INDEX_BROWSER';
33-
var DEFAULT_EVENT_BATCH_SIZE = 10;
34-
var DEFAULT_EVENT_FLUSH_INTERVAL = 1000; // Unit is ms, default is 1s
32+
const MODULE_NAME = 'INDEX_BROWSER';
33+
const DEFAULT_EVENT_BATCH_SIZE = 10;
34+
const DEFAULT_EVENT_FLUSH_INTERVAL = 1000; // Unit is ms, default is 1s
3535

3636
var hasRetriedEvents = false;
3737

38-
export var logging = loggerPlugin;
39-
export var errorHandler = defaultErrorHandler;
40-
export var eventDispatcher = defaultEventDispatcher;
41-
export var enums = utilEnums;
42-
export var setLogger = sdkLogging.setLogHandler;
43-
export var setLogLevel = sdkLogging.setLogLevel;
38+
export const logging = loggerPlugin;
39+
export const errorHandler = defaultErrorHandler;
40+
export const eventDispatcher = defaultEventDispatcher;
41+
export const enums = utilEnums;
42+
export const setLogger = sdkLogging.setLogHandler;
43+
export const setLogLevel = sdkLogging.setLogLevel;
4444

4545
/**
4646
* Creates an instance of the Optimizely class
@@ -55,7 +55,7 @@ export var setLogLevel = sdkLogging.setLogLevel;
5555
* @param {Object} config.eventFlushInterval
5656
* @return {Object} the Optimizely object
5757
*/
58-
export var createInstance = function(config) {
58+
export const createInstance = function(config) {
5959
try {
6060
config = config || {};
6161

@@ -86,7 +86,7 @@ export var createInstance = function(config) {
8686
config.skipJSONValidation = true;
8787
}
8888

89-
var eventDispatcher;
89+
let eventDispatcher;
9090
// prettier-ignore
9191
if (config.eventDispatcher == null) { // eslint-disable-line eqeqeq
9292
// only wrap the event dispatcher with pending events retry if the user didnt override
@@ -130,11 +130,11 @@ export var createInstance = function(config) {
130130
config.eventFlushInterval = DEFAULT_EVENT_FLUSH_INTERVAL;
131131
}
132132

133-
var optimizely = new Optimizely(config);
133+
const optimizely = new Optimizely(config);
134134

135135
try {
136136
if (typeof window.addEventListener === 'function') {
137-
var unloadEvent = 'onpagehide' in window ? 'pagehide' : 'unload';
137+
const unloadEvent = 'onpagehide' in window ? 'pagehide' : 'unload';
138138
window.addEventListener(
139139
unloadEvent,
140140
function() {
@@ -154,7 +154,7 @@ export var createInstance = function(config) {
154154
}
155155
};
156156

157-
export var __internalResetRetryState = function() {
157+
export const __internalResetRetryState = function() {
158158
hasRetriedEvents = false;
159159
};
160160

0 commit comments

Comments
 (0)