revert: more auto-format & clean ups (making it dirty again :-)

Author: mikechu-optimizely

.devcontainer/devcontainer.json

@@ -1,7 +1,9 @@
 {
 	"name": "Javascript SDK",
 	"image": "mcr.microsoft.com/devcontainers/typescript-node:1-18-bookworm",
+
 	"postCreateCommand": "cd /workspaces/javascript-sdk && npm install -g npm && npm install",
+
 	"customizations": {
 		"vscode": {
 			"extensions": [

lib/core/odp/odp_manager.ts

@@ -220,7 +220,7 @@ export abstract class OdpManager implements IOdpManager {
   /**
    * Identifies a user via the ODP Event Manager
    * @param {string}  userId    (Optional) Custom unique identifier of a target user.
-   * @param {string}  vuid      (Optional) Secondary unique identifier of a target user, used by client SDKs.
+   * @param {string}  vuid      (Optional) Secondary unique identifier of a target user, primarily used by client SDKs.
    * @returns
    */
   identifyUser(userId?: string, vuid?: string): void {

lib/index.browser.tests.js

@@ -128,7 +128,7 @@ describe('javascript-sdk (Browser)', function() {
             logger: silentLogger,
           });
           // Invalid datafile causes onReady Promise rejection - catch this error
-          optlyInstance.onReady().catch(function() { });
+          optlyInstance.onReady().catch(function() {});
 
           sinon.assert.calledOnce(LocalStoragePendingEventsDispatcher.prototype.sendPendingEvents);
         });

lib/index.browser.ts

@@ -182,7 +182,7 @@ const createInstance = function(config: Config): Client | null {
   }
 };
 
-const __internalResetRetryState = function (): void {
+const __internalResetRetryState = function(): void {
   hasRetriedEvents = false;
 };
 

lib/plugins/odp_manager/index.browser.ts

@@ -108,7 +108,7 @@ export class BrowserOdpManager extends OdpManager {
     }
 
     let eventManager: IOdpEventManager;
-    
+        
     if (odpOptions?.eventManager) {
       eventManager = odpOptions.eventManager;
     } else {

tests/odpManager.spec.ts

@@ -138,7 +138,7 @@ describe('OdpManager', () => {
   it('should call initialzeVuid on construction if vuid is enabled', () => {
     const vuidInitializer = jest.fn();
 
-    const odpManager =testOdpManager({
+    const odpManager = testOdpManager({
       segmentManager,
       eventManager,
       logger,
@@ -214,7 +214,7 @@ describe('OdpManager', () => {
 
     const odpIntegrationConfig: OdpNotIntegratedConfig = { integrated: false };
     odpManager.updateSettings(odpIntegrationConfig);
-
+    
     await wait(500);
     expect(odpManager.isReady()).toBe(false);
 
@@ -268,7 +268,7 @@ describe('OdpManager', () => {
     await odpManager.onReady();
     expect(odpManager.isReady()).toBe(true);
     expect(odpManager.getStatus()).toEqual(Status.Stopped);
-    verify(mockEventManager.start()).never();   
+    verify(mockEventManager.start()).never();     
   });
 
   it('should pass the integrated odp config given in constructor to eventManger and segmentManager', async () => {
@@ -280,7 +280,7 @@ describe('OdpManager', () => {
       odpConfig: new OdpConfig(keyA, hostA, pixelA, segmentsA)
     };
 
-    testOdpManager({
+    const odpManager = testOdpManager({
       odpIntegrationConfig,
       segmentManager,
       eventManager,
@@ -460,7 +460,7 @@ describe('OdpManager', () => {
     const [userIdArg2, vuidArg2] = capture(mockEventManager.identifyUser).byCallIndex(1);
     expect(userIdArg2).toEqual(userId);
     expect(vuidArg2).toEqual(undefined);
-
+    
     odpManager.identifyUser(vuid);
     const [userIdArg3, vuidArg3] = capture(mockEventManager.identifyUser).byCallIndex(2);
     expect(userIdArg3).toEqual(undefined);