Skip to content

Commit e604cbb

Browse files
committed
Add unit test for getVariationIdFromExperimentIdAndVariationKey + clean up
1 parent 2995875 commit e604cbb

File tree

2 files changed

+38
-25
lines changed

2 files changed

+38
-25
lines changed

packages/optimizely-sdk/lib/core/project_config/index.tests.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,19 @@ describe('lib/core/project_config', function() {
392392
});
393393
});
394394

395+
describe('#getVariationIdFromExperimentIdAndVariationKey', function() {
396+
it('should return the variation id for the given experiment id and variation key', function() {
397+
assert.strictEqual(
398+
projectConfig.getVariationIdFromExperimentIdAndVariationKey(
399+
configObj,
400+
testData.experiments[0].id,
401+
testData.experiments[0].variations[0].key
402+
),
403+
testData.experiments[0].variations[0].id
404+
);
405+
});
406+
});
407+
395408
describe('#getSendFlagDecisionsValue', function() {
396409
it('should return false when sendFlagDecisions is undefined', function() {
397410
configObj.sendFlagDecisions = undefined;

packages/optimizely-sdk/lib/core/project_config/index.ts

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -747,29 +747,29 @@ export const getSendFlagDecisionsValue = function(projectConfig: ProjectConfig):
747747
}
748748

749749
export default {
750-
createProjectConfig: createProjectConfig,
751-
getExperimentId: getExperimentId,
752-
getLayerId: getLayerId,
753-
getAttributeId: getAttributeId,
754-
getEventId: getEventId,
755-
getExperimentStatus: getExperimentStatus,
756-
isActive: isActive,
757-
isRunning: isRunning,
758-
getExperimentAudienceConditions: getExperimentAudienceConditions,
759-
getVariationKeyFromId: getVariationKeyFromId,
760-
getVariationIdFromExperimentAndVariationKey: getVariationIdFromExperimentAndVariationKey,
761-
getVariationIdFromExperimentIdAndVariationKey: getVariationIdFromExperimentIdAndVariationKey,
762-
getExperimentFromKey: getExperimentFromKey,
763-
getTrafficAllocation: getTrafficAllocation,
764-
getExperimentFromId: getExperimentFromId,
765-
getFeatureFromKey: getFeatureFromKey,
766-
getVariableForFeature: getVariableForFeature,
767-
getVariableValueForVariation: getVariableValueForVariation,
768-
getTypeCastValue: getTypeCastValue,
769-
getSendFlagDecisionsValue: getSendFlagDecisionsValue,
770-
getAudiencesById: getAudiencesById,
771-
eventWithKeyExists: eventWithKeyExists,
772-
isFeatureExperiment: isFeatureExperiment,
773-
toDatafile: toDatafile,
774-
tryCreatingProjectConfig: tryCreatingProjectConfig,
750+
createProjectConfig,
751+
getExperimentId,
752+
getLayerId,
753+
getAttributeId,
754+
getEventId,
755+
getExperimentStatus,
756+
isActive,
757+
isRunning,
758+
getExperimentAudienceConditions,
759+
getVariationKeyFromId,
760+
getVariationIdFromExperimentAndVariationKey,
761+
getVariationIdFromExperimentIdAndVariationKey,
762+
getExperimentFromKey,
763+
getTrafficAllocation,
764+
getExperimentFromId,
765+
getFeatureFromKey,
766+
getVariableForFeature,
767+
getVariableValueForVariation,
768+
getTypeCastValue,
769+
getSendFlagDecisionsValue,
770+
getAudiencesById,
771+
eventWithKeyExists,
772+
isFeatureExperiment,
773+
toDatafile,
774+
tryCreatingProjectConfig,
775775
};

0 commit comments

Comments
 (0)