Move LogTierV1EventProcessorConfig to eventProcessor.ts

Author: yavorona

packages/event-processor/src/eventProcessor.ts

@@ -16,7 +16,7 @@
 // TODO change this to use Managed from js-sdk-models when available
 import { Managed } from './managed'
 import { ConversionEvent, ImpressionEvent } from './events'
-import { EventV1Request } from './eventDispatcher'
+import { EventV1Request, EventDispatcher } from './eventDispatcher'
 import { EventQueue, DefaultEventQueue, SingleEventQueue } from './eventQueue'
 import { getLogger } from '@optimizely/js-sdk-logging'
 import { NOTIFICATION_TYPES, NotificationCenter } from '@optimizely/js-sdk-utils'
@@ -34,6 +34,14 @@ export interface EventProcessor extends Managed {
   process(event: ProcessableEvent): void
 }
 
+export interface LogTierV1EventProcessorConfig {
+  dispatcher: EventDispatcher;
+  flushInterval?: number;
+  batchSize?: number;
+  notificationCenter?: NotificationCenter;
+  maxQueueSize?: number;
+}
+
 export function validateAndGetFlushInterval(flushInterval: number): number {
   if (flushInterval <= 0) {
     logger.warn(

packages/optimizely-sdk/lib/optimizely/index.ts

@@ -22,9 +22,9 @@ import {
   UserAttributes,
   Variation,
   EventTags,
-  OptimizelyConfig,
-  LogTierV1EventProcessorConfig
+  OptimizelyConfig
 } from '../shared_types';
+import { LogTierV1EventProcessorConfig } from '../../../event-processor/src'
 import { createProjectConfigManager, ProjectConfigManager } from '../core/project_config/project_config_manager';
 import { createNotificationCenter, NotificationCenter } from '../core/notification_center';
 import { createDecisionService, DecisionService } from '../core/decision_service';
@@ -143,7 +143,7 @@ export default class Optimizely {
       dispatcher: this.eventDispatcher,
       flushInterval: config.eventFlushInterval,
       batchSize: config.eventBatchSize,
-      maxQueueSize: config.eventMaxQueueSize, // TODO: update event-processor to include maxQueueSize
+      maxQueueSize: config.eventMaxQueueSize,
       notificationCenter: this.notificationCenter,
     } as LogTierV1EventProcessorConfig);
 

packages/optimizely-sdk/lib/shared_types.ts

@@ -121,13 +121,3 @@ export interface OptimizelyConfig {
   getDatafile(): string;
 }
 
-/**
- * Temprorary placement of LogTierV1EventProcessorConfig
- */
-export interface LogTierV1EventProcessorConfig {
-  dispatcher: import ('@optimizely/js-sdk-event-processor').EventDispatcher;
-  flushInterval?: number;
-  batchSize?: number;
-  notificationCenter?: import('./core/notification_center').NotificationCenter;
-  maxQueueSize?: number;
-}