feat: Convert event_tags_validator module to TS (#528)

Summary:

Convert event_tags_validator module from JS to TS
Revise user_profile_service_validator module

Test plan:

Existing unit tests

Author: yavorona

packages/optimizely-sdk/lib/optimizely/index.js

@@ -22,7 +22,7 @@ import decisionService from '../core/decision_service';
 import enums from '../utils/enums';
 import { getImpressionEvent, getConversionEvent } from '../core/event_builder/index.js';
 import { buildConversionEvent, buildImpressionEvent } from '../core/event_builder/event_helpers';
-import eventTagsValidator from '../utils/event_tags_validator';
+import * as eventTagsValidator from '../utils/event_tags_validator';
 import notificationCenter from '../core/notification_center';
 import projectConfig from '../core/project_config';
 import * as userProfileServiceValidator from '../utils/user_profile_service_validator';

packages/optimizely-sdk/lib/utils/event_tags_validator/index.js renamed to packages/optimizely-sdk/lib/utils/event_tags_validator/index.ts

@@ -21,22 +21,18 @@ import { sprintf } from '@optimizely/js-sdk-utils';
 
 import { ERROR_MESSAGES } from '../enums';
 
-var MODULE_NAME = 'EVENT_TAGS_VALIDATOR';
+const MODULE_NAME = 'EVENT_TAGS_VALIDATOR';
 
 /**
  * Validates user's provided event tags
- * @param  {Object}  event tags
- * @return {boolean} True if event tags are valid
+ * @param  {unknown}  eventTags
+ * @return {boolean} true if event tags are valid
  * @throws If event tags are not valid
  */
-export var validate = function(eventTags) {
+export function validate(eventTags: unknown): boolean {
   if (typeof eventTags === 'object' && !Array.isArray(eventTags) && eventTags !== null) {
     return true;
   } else {
     throw new Error(sprintf(ERROR_MESSAGES.INVALID_EVENT_TAGS, MODULE_NAME));
   }
 }
-
-export default {
-  validate: validate,
-}

packages/optimizely-sdk/lib/utils/user_profile_service_validator/index.ts

@@ -26,15 +26,19 @@ const MODULE_NAME = 'USER_PROFILE_SERVICE_VALIDATOR';
 
 /**
  * Validates user's provided user profile service instance
- * @param  {object}  userProfileServiceInstance
+ * @param  {unknown}  userProfileServiceInstance
  * @return {boolean} true if the instance is valid
  * @throws If the instance is not valid
  */
-export function validate(userProfileServiceInstance: Record<string, unknown>): boolean {
-  if (typeof userProfileServiceInstance.lookup !== 'function') {
-    throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_PROFILE_SERVICE, MODULE_NAME, "Missing function 'lookup'"));
-  } else if (typeof userProfileServiceInstance.save !== 'function') {
-    throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_PROFILE_SERVICE, MODULE_NAME, "Missing function 'save'"));
+
+export function validate(userProfileServiceInstance: unknown): boolean {
+  if (typeof userProfileServiceInstance === 'object' && userProfileServiceInstance !== null) {
+    if (typeof userProfileServiceInstance['lookup'] !== 'function') {
+      throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_PROFILE_SERVICE, MODULE_NAME, "Missing function 'lookup'"));
+    } else if (typeof userProfileServiceInstance['save'] !== 'function') {
+      throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_PROFILE_SERVICE, MODULE_NAME, "Missing function 'save'"));
+    }
+    return true;
   }
-  return true;
+  throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_PROFILE_SERVICE, MODULE_NAME));
 }