Skip to content

Commit b9fab5e

Browse files
committed
Incorporate comments
1 parent 5d91f24 commit b9fab5e

File tree

1 file changed

+25
-7
lines changed

1 file changed

+25
-7
lines changed

packages/optimizely-sdk/lib/optimizely_user_context/index.tests.js

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ describe('lib/optimizely_user_context', function() {
2121
describe('APIs', function() {
2222
var fakeOptimizely;
2323
var userId = 'tester';
24+
var options = 'fakeOption';
2425
describe('#setAttribute', function() {
2526
fakeOptimizely = {
2627
decide: sinon.stub().returns({})
@@ -153,13 +154,19 @@ describe('lib/optimizely_user_context', function() {
153154
optimizely: fakeOptimizely,
154155
userId,
155156
});
156-
var decision = user.decide(flagKey);
157+
var decision = user.decide(flagKey, options);
158+
sinon.assert.calledWithExactly(
159+
fakeOptimizely.decide,
160+
user,
161+
flagKey,
162+
options
163+
);
157164
assert.deepEqual(decision, fakeDecision);
158165
});
159166
});
160167

161-
describe('##decideForKeys', function() {
162-
it('should return an expected decision results map', function() {
168+
describe('#decideForKeys', function() {
169+
it('should return an expected decision results object', function() {
163170
var flagKey1 = 'feature_1';
164171
var flagKey2 = 'feature_2';
165172
var fakeDecisionMap = {
@@ -191,13 +198,19 @@ describe('lib/optimizely_user_context', function() {
191198
optimizely: fakeOptimizely,
192199
userId,
193200
});
194-
var decisionMap = user.decideForKeys([ flagKey1, flagKey2 ]);
201+
var decisionMap = user.decideForKeys([ flagKey1, flagKey2 ], options);
202+
sinon.assert.calledWithExactly(
203+
fakeOptimizely.decideForKeys,
204+
user,
205+
[ flagKey1, flagKey2 ],
206+
options
207+
);
195208
assert.deepEqual(decisionMap, fakeDecisionMap);
196209
});
197210
});
198211

199-
describe('##decideAll', function() {
200-
it('should return an expected decision results map', function() {
212+
describe('#decideAll', function() {
213+
it('should return an expected decision results object', function() {
201214
var flagKey1 = 'feature_1';
202215
var flagKey2 = 'feature_2';
203216
var flagKey3 = 'feature_3';
@@ -240,7 +253,12 @@ describe('lib/optimizely_user_context', function() {
240253
optimizely: fakeOptimizely,
241254
userId,
242255
});
243-
var decisionMap = user.decideAll();
256+
var decisionMap = user.decideAll(options);
257+
sinon.assert.calledWithExactly(
258+
fakeOptimizely.decideAll,
259+
user,
260+
options
261+
);
244262
assert.deepEqual(decisionMap, fakeDecisionMap);
245263
});
246264
});

0 commit comments

Comments
 (0)