Skip to content

Commit afa41b1

Browse files
committed
fixed more unit tests
1 parent 46846d8 commit afa41b1

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

packages/optimizely-sdk/lib/utils/event_tag_utils/index.tests.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,12 @@
1515
*/
1616
import sinon from 'sinon';
1717
import { assert } from 'chai';
18+
import { sprintf } from '@optimizely/js-sdk-utils';
1819

1920
import * as eventTagUtils from './';
2021

22+
var buildLogMessageFromArgs = args => sprintf(args[1], ...args.splice(2));
23+
2124
describe('lib/utils/event_tag_utils', function() {
2225
var mockLogger;
2326
beforeEach(function() {
@@ -38,7 +41,7 @@ describe('lib/utils/event_tag_utils', function() {
3841
);
3942

4043
assert.strictEqual(parsedRevenueValue, 1337);
41-
var logMessage = mockLogger.log.args[0][1];
44+
var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
4245
assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Parsed revenue value "1337" from event tags.');
4346

4447
// test out a float
@@ -64,7 +67,7 @@ describe('lib/utils/event_tag_utils', function() {
6467

6568
assert.strictEqual(parsedRevenueValue, null);
6669

67-
var logMessage = mockLogger.log.args[0][1];
70+
var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
6871
assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Failed to parse revenue value "invalid" from event tags.');
6972
});
7073
});
@@ -94,7 +97,7 @@ describe('lib/utils/event_tag_utils', function() {
9497
);
9598

9699
assert.strictEqual(parsedEventValue, 1337);
97-
var logMessage = mockLogger.log.args[0][1];
100+
var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
98101
assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Parsed event value "1337" from event tags.');
99102

100103
// test out a float
@@ -120,7 +123,7 @@ describe('lib/utils/event_tag_utils', function() {
120123

121124
assert.strictEqual(parsedEventValue, null);
122125

123-
var logMessage = mockLogger.log.args[0][1];
126+
var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
124127
assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Failed to parse event value "invalid" from event tags.');
125128
});
126129
});

0 commit comments

Comments
 (0)