fix (datafile management): Fix unhandled onReady promise rejections in unit tests (#19)

Summary:

With changes for datafile management, we introduced Promise rejections that need to be handled. Add handlers to these expected errors.

Test plan:

Run unit tests with changes from this branch and master branch (which exits the test process on unhandled rejections)

Author: mjc1283

packages/optimizely-sdk/lib/index.browser.tests.js

@@ -74,32 +74,37 @@ describe('javascript-sdk', function() {
       });
 
       it('should invoke resendPendingEvents at most once', function() {
-        optimizelyFactory.createInstance({
+        var optlyInstance = optimizelyFactory.createInstance({
           datafile: {},
           errorHandler: fakeErrorHandler,
           eventDispatcher: fakeEventDispatcher,
           logger: silentLogger,
         });
+        // Invalid datafile causes onReady Promise rejection - catch this error
+        optlyInstance.onReady().catch(function() {});
 
         sinon.assert.calledOnce(LocalStoragePendingEventsDispatcher.prototype.sendPendingEvents);
 
-        optimizelyFactory.createInstance({
+        optlyInstance = optimizelyFactory.createInstance({
           datafile: {},
           errorHandler: fakeErrorHandler,
           eventDispatcher: fakeEventDispatcher,
           logger: silentLogger,
         });
+        optlyInstance.onReady().catch(function() {});
 
         sinon.assert.calledOnce(LocalStoragePendingEventsDispatcher.prototype.sendPendingEvents);
       });
 
       it('should not throw if the provided config is not valid', function() {
         configValidator.validate.throws(new Error('Invalid config or something'));
         assert.doesNotThrow(function() {
-          optimizelyFactory.createInstance({
+          var optlyInstance = optimizelyFactory.createInstance({
             datafile: {},
             logger: silentLogger,
           });
+          // Invalid datafile causes onReady Promise rejection - catch this error
+          optlyInstance.onReady().catch(function() {});
         });
       });
 
@@ -110,6 +115,8 @@ describe('javascript-sdk', function() {
           eventDispatcher: fakeEventDispatcher,
           logger: silentLogger,
         });
+        // Invalid datafile causes onReady Promise rejection - catch this error
+        optlyInstance.onReady().catch(function() {});
 
         assert.instanceOf(optlyInstance, Optimizely);
         assert.equal(optlyInstance.clientVersion, '3.1.0-beta1');
@@ -122,6 +129,8 @@ describe('javascript-sdk', function() {
           eventDispatcher: fakeEventDispatcher,
           logger: silentLogger,
         });
+        // Invalid datafile causes onReady Promise rejection - catch this error
+        optlyInstance.onReady().catch(function() {});
         assert.equal('javascript-sdk', optlyInstance.clientEngine);
         assert.equal(packageJSON.version, optlyInstance.clientVersion);
       });

packages/optimizely-sdk/lib/index.node.tests.js

@@ -57,20 +57,24 @@ describe('optimizelyFactory', function() {
         configValidator.validate.throws(new Error('Invalid config or something'));
         var localLogger = loggerPlugin.createLogger({ logLevel: enums.LOG_LEVEL.INFO });
         assert.doesNotThrow(function() {
-          optimizelyFactory.createInstance({
+          var optlyInstance = optimizelyFactory.createInstance({
             datafile: {},
             logger: localLogger,
           });
+          // Invalid datafile causes onReady Promise rejection - catch this
+          optlyInstance.onReady().catch(function() {});
         });
         sinon.assert.calledWith(localLogger.log, enums.LOG_LEVEL.ERROR);
       });
 
       it('should not throw if the provided config is not valid and log an error if no logger is provided', function() {
         configValidator.validate.throws(new Error('Invalid config or something'));
         assert.doesNotThrow(function() {
-          optimizelyFactory.createInstance({
+          var optlyInstance = optimizelyFactory.createInstance({
             datafile: {},
           });
+          // Invalid datafile causes onReady Promise rejection - catch this
+          optlyInstance.onReady().catch(function() {});
         });
         sinon.assert.calledOnce(console.error);
       });
@@ -82,6 +86,8 @@ describe('optimizelyFactory', function() {
           eventDispatcher: fakeEventDispatcher,
           logger: fakeLogger,
         });
+        // Invalid datafile causes onReady Promise rejection - catch this
+        optlyInstance.onReady().catch(function() {});
 
         assert.instanceOf(optlyInstance, Optimizely);
         assert.equal(optlyInstance.clientVersion, '3.1.0-beta1');