Break down and add NODE_ENV awareness to the default logger

Author: spencerwilson-optimizely

packages/optimizely-sdk/lib/plugins/logger/index.js

@@ -78,6 +78,15 @@ Logger.prototype.setLogLevel = function(logLevel) {
  * @private
  */
 Logger.prototype.__shouldLog = function(targetLogLevel) {
+  try {
+    if (process.env.NODE_ENV === 'test') {
+      // Suppress logs during testing.
+      return false;
+    }
+  } catch (e) {
+    // `process` is likely a ReferenceError in non-Node.js environments
+  }
+
   return targetLogLevel >= this.logLevel;
 };
 

packages/optimizely-sdk/lib/plugins/logger/index.tests.js

@@ -33,9 +33,20 @@ describe('lib/plugins/logger', function() {
     });
 
     describe('log', function() {
+      var nodeEnv;
+
       beforeEach(function() {
         defaultLogger = logger.createLogger({logLevel: LOG_LEVEL.INFO});
         sinon.stub(defaultLogger, '__consoleLog');
+
+        // The usual rules of turning off logging don't apply here,
+        // since the code under test _is the logger_.
+        nodeEnv = process.env.NODE_ENV;
+        process.env.NODE_ENV = 'production';
+      });
+
+      afterEach(function() {
+        process.env.NODE_ENV = nodeEnv;
       });
 
       it('should log the given message', function() {

packages/optimizely-sdk/package.json

@@ -5,7 +5,7 @@
   "main": "lib/index.node.js",
   "browser": "lib/index.browser.js",
   "scripts": {
-    "test": "mocha ./lib/*.tests.js ./lib/**/*.tests.js ./lib/**/**/*tests.js --recursive",
+    "test": "NODE_ENV=test mocha --reporter dot './lib/**/*.tests.js'",
     "test-xbrowser": "karma start karma.bs.conf.js --single-run",
     "lint": "eslint lib/**",
     "cover": "istanbul cover _mocha ./lib/*.tests.js ./lib/**/*.tests.js ./lib/**/**/*tests.js",