feat: Convert decision service to TS (#659)

* WIP

WIP Initial conversion with all unit tests pass

WIP

WIP

Define more intefaces

Define the rest of interfaces

Clean up

WIP

WIP

Finish defining remaining interfaces

Clean up

* Incorporate comments

* Sort imports alphabetically

* Fix comment

Author: yavorona

packages/optimizely-sdk/lib/core/audience_evaluator/index.d.ts

@@ -0,0 +1,26 @@
+/**
+ * Copyright 2021, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { UserAttributes, Audience } from '../../shared_types';
+
+export interface AudienceEvaluator {
+  evaluate(
+    audienceConditions: Array<string | string[]>,
+    audiencesById: { [id: string]: Audience },
+    userAttributes?: UserAttributes
+  ): boolean; 
+}
+
+export function createAudienceEvaluator(config: unknown): AudienceEvaluator;

packages/optimizely-sdk/lib/core/audience_evaluator/index.js

@@ -111,3 +111,7 @@ AudienceEvaluator.prototype.evaluateConditionWithUserAttributes = function(userA
 };
 
 export default AudienceEvaluator;
+
+export var createAudienceEvaluator = function(UNSTABLE_conditionEvaluators) {
+  return new AudienceEvaluator(UNSTABLE_conditionEvaluators);
+};

packages/optimizely-sdk/lib/core/audience_evaluator/index.tests.js

@@ -17,7 +17,7 @@ import sinon from 'sinon';
 import { assert } from 'chai';
 import { getLogger } from '@optimizely/js-sdk-logging';
 
-import AudienceEvaluator from './index';
+import { createAudienceEvaluator } from './index';
 import * as conditionTreeEvaluator from '../condition_tree_evaluator';
 import * as customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
 
@@ -85,7 +85,7 @@ describe('lib/core/audience_evaluator', function() {
   describe('APIs', function() {
     context('with default condition evaluator', function() {
       beforeEach(function() {
-        audienceEvaluator = new AudienceEvaluator();
+        audienceEvaluator = createAudienceEvaluator();
       });
       describe('evaluate', function() {
         it('should return true if there are no audiences', function() {
@@ -296,7 +296,7 @@ describe('lib/core/audience_evaluator', function() {
           const mockEnvironment = {
             special: true,
           };
-          audienceEvaluator = new AudienceEvaluator({
+          audienceEvaluator = createAudienceEvaluator({
             special_condition_type: {
               evaluate: function(condition, userAttributes, logger) {
                 const result = mockEnvironment[condition.value] && userAttributes[condition.match] > 0;
@@ -322,7 +322,7 @@ describe('lib/core/audience_evaluator', function() {
 
       describe('when passing an invalid additional evaluator', function() {
         beforeEach(function() {
-          audienceEvaluator = new AudienceEvaluator({
+          audienceEvaluator = createAudienceEvaluator({
             custom_attribute: {
               evaluate: function() {
                 return false;

packages/optimizely-sdk/lib/core/bucketer/index.ts

@@ -22,8 +22,7 @@ import murmurhash from 'murmurhash';
 import { LogHandler } from '@optimizely/js-sdk-logging';
 import {
   DecisionResponse,
-  Experiment,
-  Variation,
+  BucketerParams,
   TrafficAllocation,
   Group,
 } from '../../shared_types';
@@ -40,19 +39,6 @@ const MAX_TRAFFIC_VALUE = 10000;
 const MODULE_NAME = 'BUCKETER';
 const RANDOM_POLICY = 'random';
 
-interface BucketerParams {
-  experimentId: string;
-  experimentKey: string;
-  userId: string;
-  trafficAllocationConfig: TrafficAllocation[];
-  experimentKeyMap: { [key: string]: Experiment };
-  groupIdMap: { [key: string]: Group };
-  variationIdMap: { [id: string]: Variation } ;
-  varationIdMapKey: string;
-  logger: LogHandler;
-  bucketingId: string;
-}
-
 /**
  * Determines ID of variation to be shown for the given input params
  * @param  {Object}             bucketerParams