fix (config update): Change notification name and log message to refer to Optimizely config instead of project config (#22)

Summary:

Notification name and log messages refer to "Optimizely config" instead of "project config".

Test plan:

Updated unit test

Author: mjc1283

packages/optimizely-sdk/lib/optimizely/index.js

@@ -79,8 +79,8 @@ function Optimizely(config) {
   });
 
   this.__disposeOnUpdate = this.projectConfigManager.onUpdate(function(configObj) {
-    this.logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.UPDATED_PROJECT_CONFIG, MODULE_NAME, configObj.revision));
-    this.notificationCenter.sendNotifications(NOTIFICATION_TYPES.PROJECT_CONFIG_UPDATE);
+    this.logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.UPDATED_OPTIMIZELY_CONFIG, MODULE_NAME, configObj.revision, configObj.projectId));
+    this.notificationCenter.sendNotifications(NOTIFICATION_TYPES.OPTIMIZELY_CONFIG_UPDATE);
   }.bind(this));
 
   this.__readyPromise = this.projectConfigManager.onReady();
@@ -694,7 +694,7 @@ Optimizely.prototype._getFeatureVariableForType = function(featureKey, variableK
   var featureEnabled = false;
   var variableValue = variable.defaultValue;
   var decision = this.decisionService.getVariationForFeature(configObj, featureFlag, userId, attributes);
-  
+
   if (decision.variation !== null) {
     featureEnabled = decision.variation.featureEnabled;
     var value = projectConfig.getVariableValueForVariation(configObj, variable, decision.variation, this.logger);

packages/optimizely-sdk/lib/optimizely/index.tests.js

@@ -4906,7 +4906,7 @@ describe('lib/optimizely', function() {
       it('emits a notification when the project config manager emits a new project config object', function() {
         var listener = sinon.spy();
         optlyInstance.notificationCenter.addNotificationListener(
-          enums.NOTIFICATION_TYPES.PROJECT_CONFIG_UPDATE,
+          enums.NOTIFICATION_TYPES.OPTIMIZELY_CONFIG_UPDATE,
           listener
         );
         var newConfig = projectConfig.createProjectConfig(testData.getTestProjectConfigWithFeatures());

packages/optimizely-sdk/lib/utils/enums/index.js

@@ -136,7 +136,7 @@ exports.LOG_MESSAGES = {
   UNEXPECTED_TYPE_NULL: '%s: Audience condition %s evaluated to UNKNOWN because a null value was passed for user attribute "%s".',
   UNKNOWN_CONDITION_TYPE: '%s: Audience condition %s has an unknown condition type. You may need to upgrade to a newer release of the Optimizely SDK.',
   UNKNOWN_MATCH_TYPE: '%s: Audience condition %s uses an unknown match type. You may need to upgrade to a newer release of the Optimizely SDK.',
-  UPDATED_PROJECT_CONFIG: '%s: Updated project config to revision %s',
+  UPDATED_OPTIMIZELY_CONFIG: '%s: Updated Optimizely config to revision %s (project id %s)',
   OUT_OF_BOUNDS: '%s: Audience condition %s evaluated to UNKNOWN because the number value for user attribute "%s" is not in the range [-2^53, +2^53].',
 };
 
@@ -177,25 +177,22 @@ exports.NODE_CLIENT_VERSION = '3.1.0-beta1';
  *    - attributes {Object|undefined}
  *    - eventTags {Object|undefined}
  *    - logEvent {Object}
- *  DECISION: A decision is made in the system. i.e. user activation, 
+ *  DECISION: A decision is made in the system. i.e. user activation,
  *  feature access or feature-variable value retrieval
  *  Callbacks will receive an object argument with the following properties:
  *    - type {string}
  *    - userId {string}
  *    - attributes {Object|undefined}
  *    - decisionInfo {Object|undefined}
  *
- * PROJECT_CONFIG_UPDATE: This Optimizely instance has been updated with a new
- * project config
- * Callbacks will receive an object argument with the following properties:
- *   - oldProjectConfig {Object}
- *   - newProjectConfig {Object|null}
+ * OPTIMIZELY_CONFIG_UPDATE: This Optimizely instance has been updated with a new
+ * config
  */
 exports.NOTIFICATION_TYPES = {
   ACTIVATE: 'ACTIVATE:experiment, user_id,attributes, variation, event',
   TRACK: 'TRACK:event_key, user_id, attributes, event_tags, event',
   DECISION: 'DECISION:type, userId, attributes, decisionInfo',
-  PROJECT_CONFIG_UPDATE: 'PROJECT_CONFIG_UPDATE',
+  OPTIMIZELY_CONFIG_UPDATE: 'OPTIMIZELY_CONFIG_UPDATE',
 };
 
 exports.DECISION_INFO_TYPES = {