Skip to content

Commit 4084e4f

Browse files
mikechu-optimizelymikechu-optimizely
committed
Remove console.log & return CI
1 parent aa3bb69 commit 4084e4f

File tree

2 files changed

+85
-88
lines changed

2 files changed

+85
-88
lines changed

‎.github/workflows/javascript.yml

Lines changed: 85 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -2,71 +2,71 @@ name: Javascript
22

33
on:
44
push:
5-
branches: [ master, mike/polling-warning ]
5+
branches: [ master ]
66
pull_request:
77
branches: [ master ]
88

99
jobs:
10-
# lint_markdown_files:
11-
# uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@master
10+
lint_markdown_files:
11+
uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@master
1212

13-
# lint:
14-
# runs-on: ubuntu-latest
15-
# steps:
16-
# - uses: actions/checkout@v3
17-
# - name: Set up Node
18-
# uses: actions/setup-node@v3
19-
# with:
20-
# node-version: 14
21-
# cache-dependency-path: packages/optimizely-sdk/package-lock.json
22-
# cache: 'npm'
23-
# - name: Run linting
24-
# working-directory: ./packages/optimizely-sdk
25-
# run: |
26-
# npm install
27-
# npm run lint
13+
lint:
14+
runs-on: ubuntu-latest
15+
steps:
16+
- uses: actions/checkout@v3
17+
- name: Set up Node
18+
uses: actions/setup-node@v3
19+
with:
20+
node-version: 14
21+
cache-dependency-path: packages/optimizely-sdk/package-lock.json
22+
cache: 'npm'
23+
- name: Run linting
24+
working-directory: ./packages/optimizely-sdk
25+
run: |
26+
npm install
27+
npm run lint
2828
29-
# integration_tests:
30-
# uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
31-
# secrets:
32-
# CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
33-
# TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
29+
integration_tests:
30+
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
31+
secrets:
32+
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
33+
TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
3434

35-
# fullstack_production_suite:
36-
# uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
37-
# with:
38-
# FULLSTACK_TEST_REPO: ProdTesting
39-
# secrets:
40-
# CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
41-
# TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
35+
fullstack_production_suite:
36+
uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
37+
with:
38+
FULLSTACK_TEST_REPO: ProdTesting
39+
secrets:
40+
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
41+
TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
4242

43-
# crossbrowser_and_umd_unit_tests:
44-
# runs-on: ubuntu-latest
45-
# env:
46-
# BROWSER_STACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
47-
# BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
48-
# steps:
49-
# - uses: actions/checkout@v3
50-
# - name: Move to package
51-
# run: |
52-
# cd packages/optimizely-sdk
53-
# - name: Set up Node
54-
# uses: actions/setup-node@v3
55-
# with:
56-
# node-version: 14
57-
# cache: 'npm'
58-
# cache-dependency-path: packages/optimizely-sdk/package-lock.json
59-
# - name: Cross-browser and umd unit tests
60-
# working-directory: ./packages/optimizely-sdk
61-
# run: |
62-
# npm install
63-
# npm run test-ci
43+
crossbrowser_and_umd_unit_tests:
44+
runs-on: ubuntu-latest
45+
env:
46+
BROWSER_STACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
47+
BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
48+
steps:
49+
- uses: actions/checkout@v3
50+
- name: Move to package
51+
run: |
52+
cd packages/optimizely-sdk
53+
- name: Set up Node
54+
uses: actions/setup-node@v3
55+
with:
56+
node-version: 14
57+
cache: 'npm'
58+
cache-dependency-path: packages/optimizely-sdk/package-lock.json
59+
- name: Cross-browser and umd unit tests
60+
working-directory: ./packages/optimizely-sdk
61+
run: |
62+
npm install
63+
npm run test-ci
6464
6565
unit_tests:
6666
runs-on: ubuntu-latest
6767
strategy:
6868
matrix:
69-
node: ['14' ]
69+
node: ['14', '16', '18' ]
7070
steps:
7171
- uses: actions/checkout@v3
7272
- name: Set up Node ${{ matrix.node }}
@@ -92,37 +92,37 @@ jobs:
9292

9393
# As testing against multiple versions need this to
9494
# finish the parallel build
95-
# finish:
96-
# name: Coveralls coverage
97-
# needs: unit_tests
98-
# runs-on: ubuntu-latest
99-
# steps:
100-
# - name: Coveralls Finished
101-
# uses: coverallsapp/github-action@master
102-
# with:
103-
# github-token: ${{ secrets.github_token }}
104-
# path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info
105-
# parallel-finished: true
106-
# base-path: ./packages/optimizely-sdk
95+
finish:
96+
name: Coveralls coverage
97+
needs: unit_tests
98+
runs-on: ubuntu-latest
99+
steps:
100+
- name: Coveralls Finished
101+
uses: coverallsapp/github-action@master
102+
with:
103+
github-token: ${{ secrets.github_token }}
104+
path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info
105+
parallel-finished: true
106+
base-path: ./packages/optimizely-sdk
107107

108-
# test_sub_packages:
109-
# runs-on: ubuntu-latest
110-
# strategy:
111-
# matrix:
112-
# package: [ 'packages/utils', 'packages/event-processor', 'packages/logging', 'packages/datafile-manager']
113-
# steps:
114-
# - uses: actions/checkout@v3
115-
# - name: Move to package ${{ matrix.package }}
116-
# run: |
117-
# cd ${{ matrix.package }}
118-
# - name: Set up Node
119-
# uses: actions/setup-node@v3
120-
# with:
121-
# node-version: 14
122-
# cache: 'npm'
123-
# cache-dependency-path: ${{ matrix.package }}/package-lock.json
124-
# - name: Test sub packages
125-
# working-directory: ./${{ matrix.package }}
126-
# run: |
127-
# npm install
128-
# npm test
108+
test_sub_packages:
109+
runs-on: ubuntu-latest
110+
strategy:
111+
matrix:
112+
package: [ 'packages/utils', 'packages/event-processor', 'packages/logging', 'packages/datafile-manager']
113+
steps:
114+
- uses: actions/checkout@v3
115+
- name: Move to package ${{ matrix.package }}
116+
run: |
117+
cd ${{ matrix.package }}
118+
- name: Set up Node
119+
uses: actions/setup-node@v3
120+
with:
121+
node-version: 14
122+
cache: 'npm'
123+
cache-dependency-path: ${{ matrix.package }}/package-lock.json
124+
- name: Test sub packages
125+
working-directory: ./${{ matrix.package }}
126+
run: |
127+
npm install
128+
npm test

‎packages/optimizely-sdk/lib/modules/datafile-manager/httpPollingDatafileManager.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,6 @@ export default abstract class HttpPollingDatafileManager implements DatafileMana
166166
if (!this.isStarted) {
167167
logger.debug('Datafile manager started');
168168
this.isStarted = true;
169-
170-
console.log('>>> this.backoffController in start():', this.backoffController);
171-
172169
this.backoffController.reset();
173170
this.setDatafileFromCacheIfAvailable();
174171
this.syncDatafile();

0 commit comments

Comments
 (0)