fixed some more unit tests

Author: zashraf1985

packages/optimizely-sdk/lib/core/audience_evaluator/index.tests.js

@@ -16,11 +16,13 @@
 import sinon from 'sinon';
 import { assert } from 'chai';
 import { getLogger } from '@optimizely/js-sdk-logging';
+import { sprintf } from '@optimizely/js-sdk-utils';
 
 import { createAudienceEvaluator } from './index';
 import * as conditionTreeEvaluator from '../condition_tree_evaluator';
 import * as customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
 
+var buildLogMessageFromArgs = args => sprintf(args[1], ...args.splice(2));
 var mockLogger = getLogger();
 
 var chromeUserAudience = {
@@ -233,10 +235,10 @@ describe('lib/core/audience_evaluator', function() {
             assert.isFalse(result);
             assert.strictEqual(2, mockLogger.log.callCount);
             assert.strictEqual(
-              mockLogger.log.args[0][1],
+              buildLogMessageFromArgs(mockLogger.log.args[0]),
               'AUDIENCE_EVALUATOR: Starting to evaluate audience "1" with conditions: ["and",{"name":"device_model","value":"iphone","type":"custom_attribute"}].'
             );
-            assert.strictEqual(mockLogger.log.args[1][1], 'AUDIENCE_EVALUATOR: Audience "1" evaluated to UNKNOWN.');
+            assert.strictEqual(buildLogMessageFromArgs(mockLogger.log.args[1]), 'AUDIENCE_EVALUATOR: Audience "1" evaluated to UNKNOWN.');
           });
 
           it('logs correctly when conditionTreeEvaluator.evaluate returns true', function() {
@@ -255,10 +257,10 @@ describe('lib/core/audience_evaluator', function() {
             assert.isTrue(result);
             assert.strictEqual(2, mockLogger.log.callCount);
             assert.strictEqual(
-              mockLogger.log.args[0][1],
+              buildLogMessageFromArgs(mockLogger.log.args[0]),
               'AUDIENCE_EVALUATOR: Starting to evaluate audience "1" with conditions: ["and",{"name":"device_model","value":"iphone","type":"custom_attribute"}].'
             );
-            assert.strictEqual(mockLogger.log.args[1][1], 'AUDIENCE_EVALUATOR: Audience "1" evaluated to TRUE.');
+            assert.strictEqual(buildLogMessageFromArgs(mockLogger.log.args[1]), 'AUDIENCE_EVALUATOR: Audience "1" evaluated to TRUE.');
           });
 
           it('logs correctly when conditionTreeEvaluator.evaluate returns false', function() {
@@ -277,10 +279,10 @@ describe('lib/core/audience_evaluator', function() {
             assert.isFalse(result);
             assert.strictEqual(2, mockLogger.log.callCount);
             assert.strictEqual(
-              mockLogger.log.args[0][1],
+              buildLogMessageFromArgs(mockLogger.log.args[0]),
               'AUDIENCE_EVALUATOR: Starting to evaluate audience "1" with conditions: ["and",{"name":"device_model","value":"iphone","type":"custom_attribute"}].'
             );
-            assert.strictEqual(mockLogger.log.args[1][1], 'AUDIENCE_EVALUATOR: Audience "1" evaluated to FALSE.');
+            assert.strictEqual(buildLogMessageFromArgs(mockLogger.log.args[1]), 'AUDIENCE_EVALUATOR: Audience "1" evaluated to FALSE.');
           });
         });
       });