Skip to content

Commit 12a5bf4

Browse files
author
jordangarcia
committed
Address PR comments
1 parent f607cc3 commit 12a5bf4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/optimizely-sdk/lib/core/decision_service/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ DecisionService.prototype.__buildBucketerParams = function(experimentKey, bucket
198198
};
199199

200200
/**
201-
* Get the stored variation from the user profile for the given experiment
201+
* Pull the stored variation out of the experimentBucketMap for an experiment/userId
202202
* @param {Object} experiment
203203
* @param {String} userId
204204
* @param {Object} experimentBucketMap mapping experiment => { variation_id: <variationId> }
@@ -245,6 +245,7 @@ DecisionService.prototype.__getUserProfile = function(userId) {
245245
* @param {Object} userProfile
246246
* @param {Object} experiment
247247
* @param {Object} variation
248+
* @param {Object} experimentBucketMap
248249
*/
249250
DecisionService.prototype.__saveUserProfile = function(experiment, variation, userId, experimentBucketMap) {
250251
if (!this.userProfileService) {

packages/optimizely-sdk/lib/utils/enums/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ exports.RESERVED_EVENT_KEYWORDS = {
135135
exports.CONTROL_ATTRIBUTES = {
136136
BOT_FILTERING: '$opt_bot_filtering',
137137
BUCKETING_ID: '$opt_bucketing_id',
138-
USER_AGENT: '$opt_user_agent',
139138
STICKY_BUCKETING_KEY: '$opt_experiment_bucket_map',
139+
USER_AGENT: '$opt_user_agent',
140140
};
141141

142142
exports.JAVASCRIPT_CLIENT_ENGINE = 'javascript-sdk';

0 commit comments

Comments
 (0)