Create experimentRules array directly instead of from Map Values #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ForFeature.values().
Pull Request Test Coverage Report for Build 1827
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1820
💛 - Coveralls |
The-inside-man
requested review from
jaeopt and
msohailhussain
and removed request for
a team
jaeopt
requested changes
Aug 25, 2021
| if (experimentIds == null) { | ||
| return Collections.emptyMap(); | ||
| } | ||
|
|
||
| List<OptimizelyExperiment> experimentRulesList = new ArrayList<>(); | ||
|
|
||
| Map<String, OptimizelyExperiment> optimizelyExperimentKeyMap = new HashMap<>(); | ||
| for (String experimentId : experimentIds) { | ||
| Experiment experiment = projectConfig.getExperimentIdMapping().get(experimentId); |
There was a problem hiding this comment.
I think this line can be removed.
There was a problem hiding this comment.
Removed and checking if still passes FSC. I feel this may have been added to get around an ID issue not being present in the experimentId's list but will know after FSC runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Causing an order issue with Android-SDK
Test plan
FSC
Issues