Skip to content

Update deprecated warning to OptimizelyFeature, getExperimentsMap(). #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

Update deprecated warning to OptimizelyFeature, getExperimentsMap(). #440

merged 1 commit into from
Aug 16, 2021

Conversation

The-inside-man
Copy link
Contributor

Summary

  • Addition of deprecated warning for OptimizelyFeature.getExperimentsMap()

This function and member of OptimizelyFeature should no longer be used.
ExperimentRules and DeliveryRules including their getters are to be used in its place.

Test plan

  • FSC and IDE verification of Deprecation

Issues

  • N/A

@The-inside-man The-inside-man requested a review from a team as a code owner August 16, 2021 18:07
jaeopt
jaeopt approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man removed their assignment Aug 16, 2021
@coveralls
Copy link

coveralls commented Aug 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.401%
Totals Coverage Status
Change from base Build 1795: 0.0%
Covered Lines: 4709
Relevant Lines: 5209
💛 - Coveralls

Mat001
Mat001 approved these changes Aug 16, 2021
View reviewed changes
Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@The-inside-man The-inside-man merged commit 803103f into master Aug 16, 2021
@The-inside-man The-inside-man deleted the jbrown/deprecate branch August 16, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@The-inside-man @coveralls @Mat001 @jaeopt