Skip to content

Feat: added SDKkey and environment in datafile #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

mnoman09
Copy link
Contributor

Summary

  • Sdk key and environment keys are going to be parse in sdk and will be sent back in optimizelyConfig

Test plan

All unit tests and FSC tests should pass

added tests to verify changes
@coveralls
Copy link

coveralls commented May 27, 2021

Pull Request Test Coverage Report for Build 1715

  • 33 of 33 (100.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.399%

Files with Coverage Reduction New Missed Lines %
core-api/src/main/java/com/optimizely/ab/config/parser/JsonConfigParser.java 2 97.57%
Totals Coverage Status
Change from base Build 1699: 0.02%
Covered Lines: 4510
Relevant Lines: 4989

💛 - Coveralls

@The-inside-man The-inside-man merged commit e99f26b into master Jun 21, 2021
@The-inside-man The-inside-man deleted the mnoman/sdkKey branch June 21, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants