-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add getFeatureVariableJSON and getAllFeatureVariables apis #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
032c270
add OptimizelyJSON
jaeopt 99014d2
clean up
jaeopt 9de2535
add doc comments
jaeopt 641d215
Merge branch 'master' into jae/optimizely-json
jaeopt 69144a0
add more tests
jaeopt f319fdc
fix test
jaeopt 096bcb9
(wip) add multiple parser support to OptimizelyJSON
jaeopt 5be5f3f
split getvalue tests
jaeopt 01970f5
disable getValue for legacy parsers
jaeopt 2401784
add legacy parser tests
jaeopt afdb8be
fix tests for all parsers
jaeopt 2952834
Merge branch 'master' into jae/optimizely-json
jaeopt 24ed0d6
cleanup
jaeopt 5d45085
fix findbugs issues
jaeopt 2af6f14
cleanup
jaeopt b5db429
fix test per review
jaeopt f6e5b0f
add JSON apis and notification support
jaeopt 5bc87aa
add json-api tests
jaeopt effd75d
feat: add "json" type to FeatureVariable (#372)
jaeopt 1e45e02
fix error
jaeopt a7da2d5
fix tests
jaeopt 87ac956
fix error for getAllFeatureVariables
jaeopt 734ec13
fix tests for json apis
jaeopt 81375d6
fix notification error
jaeopt 940939a
merge master
jaeopt 1bddf80
cleanup
jaeopt 8c45ed2
add tests for coverage
jaeopt 5f2a23e
cleanup
jaeopt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done in convertStringToType() like the others ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need notification map type different from the return OptimizelyJSON type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the comment, convertStringToType() is used only for notification listener. You already have a case there for json type, can you return a map there ?