feat: add getFeatureVariableJSON and getAllFeatureVariables apis #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawels-optimizely
approved these changes
May 5, 2020
| @@ -671,6 +711,10 @@ public String getFeatureVariableString(@Nonnull String featureKey, | |||
| } | |||
|
|
|||
| Object convertedValue = convertStringToType(variableValue, variableType); | |||
| Object notificationValue = convertedValue; | |||
There was a problem hiding this comment.
can this be done in convertStringToType() like the others ?
There was a problem hiding this comment.
We need notification map type different from the return OptimizelyJSON type.
There was a problem hiding this comment.
according to the comment, convertStringToType() is used only for notification listener. You already have a case there for json type, can you return a map there ?
| Map<String, Object> valuesMap = new HashMap<String, Object>(); | ||
| for (FeatureVariable variable : featureFlag.getVariables()) { | ||
| String value = variable.getDefaultValue(); | ||
| if (featureEnabled && variation != null) { |
There was a problem hiding this comment.
not sure if we need to check for null variation here.
There was a problem hiding this comment.
Removed. A good catch.
Pull Request Test Coverage Report for Build 1394
💛 - Coveralls |
mikecdavis
approved these changes
May 7, 2020
Comment on lines
19
to
22
| import com.google.gson.JsonElement; | ||
| import com.google.gson.JsonIOException; | ||
| import com.google.gson.JsonSyntaxException; | ||
| import com.google.gson.stream.JsonWriter; |
There was a problem hiding this comment.
Why were these imports added?
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| import com.google.gson.Gson; | |||
| import com.google.gson.GsonBuilder; | |||
| import com.google.gson.JsonSyntaxException; | |||
This was referenced Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary