[HttpProjectConfigManager] Change "Fetching datafile from" log to debug level #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug level Info level logging on this is causing us two problems: 1) It's spamming our logs (which company wide are info) with this log line 2) We don't want the datafile name, which happens to correspond to the api key in our logs either Debug solves both of these and we can optionally turn it on if we are seeing issues with datafile fetching.
mikecdavis
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thanks @kapin, the change looks good to me. If you can sign the Contributor License Agreement (CLA) I'll get this merged right away.
|
@mikecdavis done |
|
Would you also be able to retry the builds? The errors look unrelated to my change |
Pull Request Test Coverage Report for Build 1357
💛 - Coveralls |
|
Builds are all passing now. Gonna merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change logging "Fetching data file from..." to debug level from info.
Info level logging on this is causing us two problems:
Debug solves both of these and we can optionally turn it on if we are seeing issues with datafile fetching.
Test plan
N/A, only logging level
Issues
N/A