Skip to content

Update changelog. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2019
Merged

Update changelog. #304

merged 3 commits into from
May 23, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Update changelog for 3.2.0

@mikecdavis mikecdavis requested a review from aliabbasrizvi May 22, 2019 22:06
@coveralls
Copy link

coveralls commented May 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.741%
Totals Coverage Status
Change from base Build 1067: 0.0%
Covered Lines: 3298
Relevant Lines: 3675
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM

CHANGELOG.md Outdated
@@ -1,5 +1,26 @@
# Optimizely Java X SDK Changelog

## 3.2.0
May 22th, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. May 22nd.

CHANGELOG.md Outdated
@@ -1,5 +1,26 @@
# Optimizely Java X SDK Changelog

## 3.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call this 3.2.0-alpha

CHANGELOG.md
## 3.2.0
May 22th, 2019

### New Features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also capture that AsyncEventHandler now has a builder.

aliabbasrizvi
aliabbasrizvi reviewed May 23, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,27 @@
# Optimizely Java X SDK Changelog

## 3.2.0-alpha
May 22nd, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be May 23rd now if we release tomorrow.

@mikecdavis mikecdavis merged commit 3fbabc2 into master May 23, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-4693-update-changelog branch May 23, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecdavis @coveralls @aliabbasrizvi