Refact: Copying attributes into new copiedAttributes variable #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 694
💛 - Coveralls |
Pull Request Test Coverage Report for Build 750
💛 - Coveralls |
mikeproeng37
suggested changes
Oct 12, 2018
There was a problem hiding this comment.
Is there any reason we don't perform the copy inside of the filterAttributes methods? That way we don't have to be calling two methods all over the place. Maybe the naming could change, @thomaszurkan-optimizely any thoughts?
| @@ -818,6 +827,20 @@ public UserProfileService getUserProfileService() { | |||
|
|
|||
| //======== Helper methods ========// | |||
|
|
|||
| /** | |||
| * Helper function to check that the provided attributes are null if not than it returns a copy | |||
There was a problem hiding this comment.
This description is wrong =)
# Conflicts: # core-api/src/main/java/com/optimizely/ab/Optimizely.java
mikeproeng37
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.