Skip to content

rename ActivateNotification to ActivateNotificationListener same with… #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

… TrackNotificationListener

Copy link
Contributor

@wangjoshuah wangjoshuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor mostly looks good. just remember to remove unused imports.

@@ -1,30 +1,34 @@
package com.optimizely.ab.notification;

import ch.qos.logback.classic.Level;
import com.optimizely.ab.config.Experiment;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you have some unused imports. make sure to clear them

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 71280f5 into master Jan 31, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the refactor/notifications branch January 31, 2018 22:09
thomaszurkan-optimizely added a commit that referenced this pull request Jan 31, 2018
#166)

* rename ActivateNotification to ActivateNotificationListener same with TrackNotificationListener

* remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants