Skip to content

Merge master onto 2.0.x for beta2 release #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2017
Merged

Merge master onto 2.0.x for beta2 release #150

merged 2 commits into from
Oct 6, 2017

Conversation

wangjoshuah
Copy link
Contributor

  • if no live variable usage exists for the variable in the variation, return the default value
  • add rollout with variation that does not change variable value in rollout rule. This means no live variable usage will be in datafile. need to fallback on default value
  • add test to make sure we fall back on default value when variable usage not found in datafile

@wangjoshuah
patch live variable usage not found (#149)
69a2dd6 
* if no live variable usage exists for the variable in the variation, return the default value
* add rollout with variation that does not change variable value in rollout rule. This means no live variable usage will be in datafile. need to fallback on default value
* add test to make sure we fall back on default value when variable usage not found in datafile
@wangjoshuah wangjoshuah changed the title patch live variable usage not found (#149) Merge master onto 2.0.x for beta2 release Oct 6, 2017
@wangjoshuah wangjoshuah merged commit 3c08efc into 2.0.x Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wangjoshuah