Skip to content

Commit e648907

Browse files
committed
Added caching
1 parent e6ca657 commit e648907

File tree

3 files changed

+66
-1
lines changed

3 files changed

+66
-1
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
import com.optimizely.ab.event.internal.*;
2929
import com.optimizely.ab.event.internal.payload.EventBatch;
3030
import com.optimizely.ab.notification.*;
31+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfig;
32+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfigManager;
33+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfigService;
3134
import org.slf4j.Logger;
3235
import org.slf4j.LoggerFactory;
3336

@@ -85,6 +88,8 @@ public class Optimizely implements AutoCloseable {
8588

8689
private final ProjectConfigManager projectConfigManager;
8790

91+
private OptimizelyConfigManager optimizelyConfigManager;
92+
8893
// TODO should be private
8994
public final NotificationCenter notificationCenter;
9095

@@ -105,6 +110,9 @@ private Optimizely(@Nonnull EventHandler eventHandler,
105110
this.decisionService = decisionService;
106111
this.userProfileService = userProfileService;
107112
this.projectConfigManager = projectConfigManager;
113+
if (projectConfigManager instanceof OptimizelyConfigManager) {
114+
this.optimizelyConfigManager = (OptimizelyConfigManager)projectConfigManager;
115+
}
108116
this.notificationCenter = notificationCenter;
109117
}
110118

@@ -912,6 +920,23 @@ private boolean validateUserId(String userId) {
912920
return true;
913921
}
914922

923+
/**
924+
* Get {@link OptimizelyConfig} containing experiments and features map
925+
*
926+
* @return {@link OptimizelyConfig}
927+
*/
928+
public OptimizelyConfig getOptimizelyConfig() {
929+
ProjectConfig projectConfig = getProjectConfig();
930+
if (projectConfig == null) {
931+
logger.error("Optimizely instance is not valid, failing getOptimizelyConfig call.");
932+
return null;
933+
}
934+
if (optimizelyConfigManager != null) {
935+
return optimizelyConfigManager.getOptimizelyConfig();
936+
}
937+
return new OptimizelyConfigService(projectConfig).getConfig();
938+
}
939+
915940
/**
916941
* Helper method which makes separate copy of attributesMap variable and returns it
917942
*

core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818

1919
import com.optimizely.ab.notification.NotificationCenter;
2020
import com.optimizely.ab.notification.UpdateConfigNotification;
21+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfig;
22+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfigManager;
23+
import com.optimizely.ab.optimizelyconfig.OptimizelyConfigService;
2124
import org.slf4j.Logger;
2225
import org.slf4j.LoggerFactory;
2326

@@ -37,12 +40,13 @@
3740
* is initially set. A default ProjectConfig can be provided to bootstrap the initial ProjectConfig
3841
* return value and prevent blocking.
3942
*/
40-
public abstract class PollingProjectConfigManager implements ProjectConfigManager, AutoCloseable {
43+
public abstract class PollingProjectConfigManager implements ProjectConfigManager, AutoCloseable, OptimizelyConfigManager {
4144

4245
private static final Logger logger = LoggerFactory.getLogger(PollingProjectConfigManager.class);
4346
private static final UpdateConfigNotification SIGNAL = new UpdateConfigNotification();
4447

4548
private final AtomicReference<ProjectConfig> currentProjectConfig = new AtomicReference<>();
49+
private final AtomicReference<OptimizelyConfig> currentOptimizelyConfig = new AtomicReference<>();
4650
private final ScheduledExecutorService scheduledExecutorService;
4751
private final long period;
4852
private final TimeUnit timeUnit;
@@ -99,6 +103,7 @@ void setConfig(ProjectConfig projectConfig) {
99103
logger.info("New datafile set with revision: {}. Old revision: {}", projectConfig.getRevision(), previousRevision);
100104

101105
currentProjectConfig.set(projectConfig);
106+
currentOptimizelyConfig.set(new OptimizelyConfigService(currentProjectConfig.get()).getConfig());
102107
countDownLatch.countDown();
103108
notificationCenter.send(SIGNAL);
104109
}
@@ -132,6 +137,15 @@ public ProjectConfig getConfig() {
132137
return projectConfig == null ? currentProjectConfig.get() : projectConfig;
133138
}
134139

140+
/**
141+
* Returns the cached {@link OptimizelyConfig}
142+
* @return {@link OptimizelyConfig}
143+
*/
144+
@Override
145+
public OptimizelyConfig getOptimizelyConfig() {
146+
return currentOptimizelyConfig.get();
147+
}
148+
135149
public synchronized void start() {
136150
if (started) {
137151
logger.warn("Manager already started.");
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
/**
2+
*
3+
* Copyright 2019, Optimizely and contributors
4+
*
5+
* Licensed under the Apache License, Version 2.0 (the "License");
6+
* you may not use this file except in compliance with the License.
7+
* You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
package com.optimizely.ab.optimizelyconfig;
18+
19+
public interface OptimizelyConfigManager {
20+
/**
21+
* Implementations of this method should return {@link OptimizelyConfig}
22+
*
23+
* @return {@link OptimizelyConfig}
24+
*/
25+
OptimizelyConfig getOptimizelyConfig();
26+
}

0 commit comments

Comments
 (0)