Skip to content

Commit bfcc7a0

Browse files
committed
Finalized the unit tests for review
1 parent 8b08c61 commit bfcc7a0

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.junit.Before;
2121
import org.junit.Test;
2222
import org.junit.runner.RunWith;
23-
import org.mockito.Mock;
2423
import org.mockito.runners.MockitoJUnitRunner;
2524

2625
import java.util.*;
@@ -31,14 +30,14 @@
3130
public class OptimizelyConfigServiceTest {
3231

3332
private ProjectConfig projectConfig;
34-
@Mock
3533
private OptimizelyConfigService optimizelyConfigService;
36-
private OptimizelyConfig exptectedConfig = getExpectedConfig();
34+
private OptimizelyConfig exptectedConfig;
3735

3836
@Before
39-
public void initialize() throws Exception {
37+
public void initialize() {
4038
projectConfig = generateOptimizelyConfig();
4139
optimizelyConfigService = new OptimizelyConfigService(projectConfig);
40+
exptectedConfig = getExpectedConfig();
4241
}
4342

4443
@Test
@@ -64,12 +63,13 @@ public void testGetFeaturesMap() {
6463

6564
@Test
6665
public void testGetFeatureVariablesMap() {
67-
List<FeatureFlag> featureFlags = projectConfig.getFeatureFlags();
68-
featureFlags.forEach(featureFlag -> {
69-
Map<String, OptimizelyVariable> optimizelyVariableMap =
70-
optimizelyConfigService.getFeatureVariablesMap(featureFlag.getVariables());
71-
assertEquals(exptectedConfig.getFeaturesMap().get(featureFlag.getKey()).getVariablesMap(), optimizelyVariableMap);
72-
});
66+
FeatureFlag featureFlag = projectConfig.getFeatureFlags().get(1);
67+
Map<String, OptimizelyVariable> optimizelyVariableMap =
68+
optimizelyConfigService.getFeatureVariablesMap(featureFlag.getVariables());
69+
Map<String, OptimizelyVariable> expectedVariablesMap =
70+
exptectedConfig.getFeaturesMap().get("multi_variate_feature").getVariablesMap();
71+
assertEquals(expectedVariablesMap.size(), optimizelyVariableMap.size());
72+
assertEquals(expectedVariablesMap, optimizelyVariableMap);
7373
}
7474

7575
@Test

0 commit comments

Comments
 (0)