add more tests for reasons

Author: jaeopt

core-api/src/main/java/com/optimizely/ab/config/audience/UserAttribute.java

@@ -85,7 +85,8 @@ public Boolean evaluate(ProjectConfig config,
         Object userAttributeValue = attributes.get(name);
 
         if (!"custom_attribute".equals(type)) {
-            logger.warn("Audience condition \"{}\" uses an unknown condition type. You may need to upgrade to a newer release of the Optimizely SDK.", this);
+            String message = reasons.addInfoF("Audience condition \"%s\" uses an unknown condition type. You may need to upgrade to a newer release of the Optimizely SDK.", this);
+            logger.warn(message);
             return null; // unknown type
         }
         // check user attribute value is equal
@@ -100,26 +101,27 @@ public Boolean evaluate(ProjectConfig config,
         } catch(UnknownValueTypeException e) {
             if (!attributes.containsKey(name)) {
                 //Missing attribute value
-                logger.debug("Audience condition \"{}\" evaluated to UNKNOWN because no value was passed for user attribute \"{}\"", this, name);
+                String message = reasons.addInfoF("Audience condition \"%s\" evaluated to UNKNOWN because no value was passed for user attribute \"%s\"", this, name);
+                logger.debug(message);
             } else {
                 //if attribute value is not valid
                 if (userAttributeValue != null) {
-                    logger.warn(
-                        "Audience condition \"{}\" evaluated to UNKNOWN because a value of type \"{}\" was passed for user attribute \"{}\"",
+                    String message = reasons.addInfoF("Audience condition \"%s\" evaluated to UNKNOWN because a value of type \"%s\" was passed for user attribute \"%s\"",
                         this,
                         userAttributeValue.getClass().getCanonicalName(),
                         name);
+                    logger.warn(message);
                 } else {
-                    logger.debug(
-                        "Audience condition \"{}\" evaluated to UNKNOWN because a null value was passed for user attribute \"{}\"",
-                        this,
-                        name);
+                    String message = reasons.addInfoF("Audience condition \"%s\" evaluated to UNKNOWN because a null value was passed for user attribute \"%s\"", this, name);
+                    logger.debug(message);
                 }
             }
         } catch (UnknownMatchTypeException | UnexpectedValueTypeException e) {
-            logger.warn("Audience condition \"{}\" " + e.getMessage(), this);
+            String message = reasons.addInfoF("Audience condition \"%s\" " + e.getMessage(), this);
+            logger.warn(message);
         } catch (NullPointerException e) {
-            logger.error("attribute or value null for match {}", match != null ? match : "legacy condition", e);
+            String message = reasons.addInfoF("attribute or value null for match %s", match != null ? match : "legacy condition");
+            logger.error(message, e);
         }
         return null;
     }