Skip to content

Commit 0ea5e2a

Browse files
committed
removed unused imports
1 parent d8de41d commit 0ea5e2a

File tree

2 files changed

+29
-33
lines changed

2 files changed

+29
-33
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
import com.optimizely.ab.bucketing.FeatureDecision;
2222
import com.optimizely.ab.bucketing.UserProfileService;
2323
import com.optimizely.ab.config.*;
24-
import com.optimizely.ab.optimizelyconfig.OptimizelyConfig;
25-
import com.optimizely.ab.optimizelyconfig.OptimizelyConfigService;
2624
import com.optimizely.ab.config.parser.ConfigParseException;
2725
import com.optimizely.ab.error.ErrorHandler;
2826
import com.optimizely.ab.error.NoOpErrorHandler;

core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java

Lines changed: 29 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -43,37 +43,6 @@ public void initialize() throws Exception {
4343
optimizelyConfigService = new OptimizelyConfigService(projectConfig);
4444
}
4545

46-
@Test
47-
public void testGetMergedVariablesMap() {
48-
List<Experiment> experiments = projectConfig.getExperiments();
49-
experiments.forEach(experiment ->
50-
experiment.getVariations().forEach(variation -> {
51-
// creating temporary variable map to get values while merging
52-
Map<String, OptimizelyVariable> tempVariableIdMap =
53-
optimizelyConfigService.getFeatureVariableUsageInstanceMap(variation.getFeatureVariableUsageInstances());
54-
String featureKey = optimizelyConfigService.getExperimentFeatureKey(experiment.getId());
55-
if (featureKey != null) {
56-
// keeping all the feature variables for asserting
57-
List<FeatureVariable> featureVariables =
58-
optimizelyConfigService.generateFeatureKeyToVariablesMap().get(featureKey);
59-
Map<String, OptimizelyVariable> optimizelyVariableMap =
60-
optimizelyConfigService.getMergedVariablesMap(variation, experiment.getId());
61-
featureVariables.forEach(featureVariable -> {
62-
OptimizelyVariable optimizelyVariable = optimizelyVariableMap.get(featureVariable.getKey());
63-
assertEquals(optimizelyVariable.getKey(), featureVariable.getKey());
64-
assertEquals(optimizelyVariable.getId(), featureVariable.getId());
65-
assertEquals(optimizelyVariable.getType(), featureVariable.getType().getVariableType().toLowerCase());
66-
// getting the expected value to assert after merging
67-
String expectedValue = variation.getFeatureEnabled() && tempVariableIdMap.get(featureVariable.getId()) != null
68-
? tempVariableIdMap.get(featureVariable.getId()).getValue()
69-
: featureVariable.getDefaultValue();
70-
assertEquals(optimizelyVariable.getValue(), expectedValue);
71-
});
72-
}
73-
})
74-
);
75-
}
76-
7746
@Test
7847
public void testGetExperimentsMap() {
7948
Map<String, OptimizelyExperiment> optimizelyExperimentMap = optimizelyConfigService.getExperimentsMap();
@@ -223,6 +192,35 @@ public void testGenerateFeatureKeyToVariablesMap() {
223192
});
224193
}
225194

195+
@Test
196+
public void testGetMergedVariablesMap() {
197+
List<Experiment> experiments = projectConfig.getExperiments();
198+
experiments.forEach(experiment ->
199+
experiment.getVariations().forEach(variation -> {
200+
// creating temporary variable map to get values while merging
201+
Map<String, OptimizelyVariable> tempVariableIdMap = optimizelyConfigService.getFeatureVariableUsageInstanceMap(variation.getFeatureVariableUsageInstances());
202+
String featureKey = optimizelyConfigService.getExperimentFeatureKey(experiment.getId());
203+
if (featureKey != null) {
204+
// keeping all the feature variables for asserting
205+
List<FeatureVariable> featureVariables = optimizelyConfigService.generateFeatureKeyToVariablesMap().get(featureKey);
206+
Map<String, OptimizelyVariable> optimizelyVariableMap = optimizelyConfigService.getMergedVariablesMap(variation, experiment.getId());
207+
featureVariables.forEach(featureVariable -> {
208+
OptimizelyVariable optimizelyVariable = optimizelyVariableMap.get(featureVariable.getKey());
209+
assertEquals(optimizelyVariable.getKey(), featureVariable.getKey());
210+
assertEquals(optimizelyVariable.getId(), featureVariable.getId());
211+
assertEquals(optimizelyVariable.getType(), featureVariable.getType().getVariableType().toLowerCase());
212+
// getting the expected value to assert after merging
213+
// if feature is enabled, then value should be taken from varition variable otherwise default value from feature variable is used.
214+
String expectedValue = variation.getFeatureEnabled() && tempVariableIdMap.get(featureVariable.getId()) != null
215+
? tempVariableIdMap.get(featureVariable.getId()).getValue()
216+
: featureVariable.getDefaultValue();
217+
assertEquals(optimizelyVariable.getValue(), expectedValue);
218+
});
219+
}
220+
})
221+
);
222+
}
223+
226224
private List<Experiment> getAllExperimentsFromDatafile() {
227225
List<Experiment> experiments = new ArrayList<>();
228226
projectConfig.getGroups().forEach(group ->

0 commit comments

Comments
 (0)