get rid of magic numbers

Author: wangjoshuah

core-api/src/main/java/com/optimizely/ab/config/parser/JsonConfigParser.java

@@ -72,14 +72,14 @@ public ProjectConfig parseProjectConfig(@Nonnull String json) throws ConfigParse
 
             boolean anonymizeIP = false;
             List<LiveVariable> liveVariables = null;
-            if (datafileVersion >= 3) {
+            if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V3.toString())) {
                 liveVariables = parseLiveVariables(rootObject.getJSONArray("variables"));
 
                 anonymizeIP = rootObject.getBoolean("anonymizeIP");
             }
 
             List<FeatureFlag> featureFlags = null;
-            if (datafileVersion >= 4) {
+            if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString())) {
                 featureFlags = parseFeatureFlags(rootObject.getJSONArray("featureFlags"));
             }
 

core-api/src/main/java/com/optimizely/ab/config/parser/JsonSimpleConfigParser.java

@@ -74,14 +74,14 @@ public ProjectConfig parseProjectConfig(@Nonnull String json) throws ConfigParse
 
             boolean anonymizeIP = false;
             List<LiveVariable> liveVariables = null;
-            if (datafileVersion >= 3) {
+            if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V3.toString())) {
                 liveVariables = parseLiveVariables((JSONArray)rootObject.get("variables"));
 
                 anonymizeIP = (Boolean)rootObject.get("anonymizeIP");
             }
 
             List<FeatureFlag> featureFlags = null;
-            if (datafileVersion >= 4) {
+            if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString())) {
                 featureFlags = parseFeatureFlags((JSONArray) rootObject.get("featureFlags"));
             }
 

core-api/src/main/java/com/optimizely/ab/config/parser/ProjectConfigGsonDeserializer.java

@@ -72,15 +72,15 @@ public ProjectConfig deserialize(JsonElement json, Type typeOfT, JsonDeserializa
         boolean anonymizeIP = false;
         // live variables should be null if using V2
         List<LiveVariable> liveVariables = null;
-        if (datafileVersion >= 3) {
+        if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V3.toString())) {
             Type liveVariablesType = new TypeToken<List<LiveVariable>>() {}.getType();
             liveVariables = context.deserialize(jsonObject.getAsJsonArray("variables"), liveVariablesType);
 
             anonymizeIP = jsonObject.get("anonymizeIP").getAsBoolean();
         }
 
         List<FeatureFlag> featureFlags = null;
-        if (datafileVersion >= 4) {
+        if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString())) {
             Type featureFlagsType = new TypeToken<List<FeatureFlag>>() {}.getType();
             featureFlags = context.deserialize(jsonObject.getAsJsonArray("featureFlags"), featureFlagsType);
         }

core-api/src/main/java/com/optimizely/ab/config/parser/ProjectConfigJacksonDeserializer.java

@@ -67,14 +67,14 @@ public ProjectConfig deserialize(JsonParser parser, DeserializationContext conte
 
         boolean anonymizeIP = false;
         List<LiveVariable> liveVariables = null;
-        if (datafileVersion >= 3) {
+        if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V3.toString())) {
             liveVariables = mapper.readValue(node.get("variables").toString(),
                                              new TypeReference<List<LiveVariable>>() {});
             anonymizeIP = node.get("anonymizeIP").asBoolean();
         }
 
         List<FeatureFlag> featureFlags = null;
-        if (datafileVersion >= 4) {
+        if (datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString())) {
             featureFlags = mapper.readValue(node.get("featureFlags").toString(),
                    new TypeReference<List<FeatureFlag>>() {});
         }