IO/STL: speedup reading of ASCII files #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
IO.STL.optimize.read
branch
from
914f090
to
bdf00ea
Compare
edoardolombardi
approved these changes
Oct 22, 2020
andrea-iob
force-pushed
the
IO.STL.optimize.read
branch
from
bdf00ea
to
0958b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speedup is achieved using a custom stream instead of the std::stingstream.
With these changes, the time it takes to generate a SurfUnstructured patch form an ASCII file of 450k triangles goes from 11.3 seconds to 9.3 seconds.