Skip to content

Commit 1cea6f7

Browse files
committed
refactor(storage): remove FabricsPath
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
1 parent da48621 commit 1cea6f7

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

storage/v1alpha1/backend_nvme.proto

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -215,25 +215,15 @@ message NvmePath {
215215
// xPU's PCI/Fabrics endpoint for the controller.
216216
// One of the values is required
217217
// see https://github.com/aip-dev/google.aip.dev/issues/1147 for field_behavior annotations
218-
oneof path {
218+
oneof endpoint {
219219
// Required for pcie transport type.
220220
PciEndpoint pcie = 4 [(google.api.field_behavior) = OPTIONAL];
221221

222222
// Required for Nvme over fabrics transport types
223-
FabricsPath fabrics = 5 [(google.api.field_behavior) = OPTIONAL];
223+
FabricsEndpoint fabrics = 5 [(google.api.field_behavior) = OPTIONAL];
224224
}
225225
}
226226

227-
// Represents Fabrics transport path parameters
228-
message FabricsPath {
229-
230-
// Destination fabrics endpoint
231-
FabricsEndpoint dst = 1 [(google.api.field_behavior) = REQUIRED];
232-
233-
// Source fabrics endpoint
234-
FabricsEndpoint src = 3 [(google.api.field_behavior) = OPTIONAL];
235-
}
236-
237227
// Represent Nvme namespace created on bridge after connection to a target
238228
message NvmeRemoteNamespace {
239229
// namespace's unique key. Assign to middle/front-end objects.

storage/v1alpha1/opicommon.proto

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,14 @@ message FabricsEndpoint {
7272

7373
// address family
7474
NvmeAddressFamily adrfam = 3 [(google.api.field_behavior) = REQUIRED];
75+
76+
// source address (e.g. IP of local NIC)
77+
// not used for frontend
78+
string source_traddr = 4 [(google.api.field_behavior) = OPTIONAL];
79+
80+
// source port (e.g. Port of local NIC)
81+
// not used for frontend
82+
string source_trsvcid = 5 [(google.api.field_behavior) = OPTIONAL];
7583
}
7684

7785
// Represents Volume statistics

0 commit comments

Comments
 (0)