Difference between HasValidBundle and InvalidBundleContent?

[joelanford]

I see that our plain and helm provisioners use both HasValidBundle and InvalidBundleContent condition types. At a glance these seem duplicative, which could cause UX confusion.

I propose that we remove InvalidBundleContent and use HasValidBundle == "False" in its place.

[timflannagan]

Do we need multiple bundle conditions at the BD controller level? Can we have a single Unpacked condition, and derive any validation or unpack failures there?

[joelanford]

Yeah, that's essentially what I'm saying. If there's a better name than HasValidBundle, we can change that too. For this issue I was primarily focused on "let's have one rather than two", and less on "what should the name of the one be".

[timflannagan]

Works for me. This would be a welcomed change from my perspective, and should help reduce the complexity in our BD controllers. We can tentatively slate this for next release.

[timflannagan]

Related to #333 and #331. The first issue looks like a potential duplicate of this one?