Adding context timeout for Ansible proxy

[camilamacedo86]

Description of the change:
Add timeout in the watch feature for Ansible based-operators proxy to avoid appears that the reconcile is stuck and hang when the operator has not the correct permissions to List and Watch the resources.

Motivation for the change:

• Bug 1701041: Adding timeout on dependent watch establishment #1638
• https://bugzilla.redhat.com/show_bug.cgi?id=1701041

Note
Also, solved by kubernetes-sigs/controller-runtime#663.

Steps to test it locally

• Build an ansible image with this PR
• Use the image in an ansible POC ( can be the Memchaced sample )
• Remove the required permission to perform some operations defined in the playbook/roles. E.g to create a resource.
• After installing the CR which will call the playbook/role check in the logs the permissions issues and then verify that the CR will be updated properly with the error faced.
  PS.: The tests made to verify this fix was by removing the deployment permission.

[openshift-ci-robot]

@camilamacedo86: This pull request references Bugzilla bug 1701041, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.4.0" release, but it targets "4.2.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1701041: Adding timeout on dependent watch establishment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joelanford]

@camilamacedo86 @shawn-hurley @fabianvf The BZ for this issue was verified and closed over a month ago. Is this PR an improvement on that fix, or should the BZ be re-opened?

[camilamacedo86]

@joelanford I understand that the Bugzilla was closed because automatically when we close the PR #1638 and carry on @shawn-hurley code here.

[joelanford]

Will this PR be made obsolete (or at least much simpler) with kubernetes-sigs/controller-runtime#663?

EDIT: Looking at that other PR closer, I think it is required to be merged before my suggestion will work.

[camilamacedo86]

Hi @joelanford,

Sorry, your comment #2264 (comment) is not clear.

EDIT: Looking at that other PR closer, I think it is required to be merged before my suggestion will work.

What do you mean with I think it is required to be merged before my suggestion will work.? What suggestion? Here or there? What do you think that is required to be merged first? Is the PR kubernetes-sigs/controller-runtime#663 or this one without address your comments?

[openshift-ci-robot]

@camilamacedo86: This pull request references Bugzilla bug 1701041, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.4.0" release, but it targets "4.2.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP: Bug 1701041: Adding timeout on dependent watch establishment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@camilamacedo86: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Adding context timeout for Ansible proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

Hi @joelanford and @fabianvf,

I think that all is properly addressed now. Could you please check this one?

[joelanford]

Sorry one more suggestion, I skipped right past this the first time around! LGTM after addressing it.

[joelanford]

Just a little cleanup to provide more clarity about the fix.

Suggested change

	Fix issue by adding proxy timeout for the Ansible based-operators to add error conditional status properly when the operator has not the required permissions (RBAC) to perform the operations.
	Added timeout to child resource watches for Ansible based-operators. This is necessary to avoid blocking the reconciler when the operator does not have the required RBAC permissions to list and watch the child resource.

[camilamacedo86]

Hi @joelanford
The reconcile was NOT blocked before this fix. (Just missing the status.conditions)
Applied your suggestion with a small change to clarifies it.

[fabianvf]

Maybe something like Added timeout to the Ansible Operator proxy, which enables error reporting for requests that fail due to RBAC permissions issues

[camilamacedo86]

very good :-)

[camilamacedo86]

@fabianvf done

[estroz]

/cherry-pick v0.17.x

[openshift-cherrypick-robot]

@estroz: new pull request created: #3025

In response to this:

/cherry-pick v0.17.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.