Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping operator-framework API dependency to v0.11.1 breaks OLM #2573

Open
fgiloux opened this issue Jan 19, 2022 · 1 comment
Open

Bumping operator-framework API dependency to v0.11.1 breaks OLM #2573

fgiloux opened this issue Jan 19, 2022 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triaged Issue has been considered by a member of the OLM community

Comments

@fgiloux
Copy link
Contributor

fgiloux commented Jan 19, 2022

Bug Report

What did you do?
Bumped OLM dependency to v0.11.1 (the current latest)

What did you expect to see?
OLM needs to work with the newer API version

What did you see instead? Under which circumstances?
Build failed due to the newer version of k8s.io/api to v0.23.0:

Error: pkg/controller/operators/suite_test.go:91:3: cannot use []"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1".CustomResourceDefinition{...} (type []"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1".CustomResourceDefinition) as type []*"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1".CustomResourceDefinition in field value
# github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler
Error: pkg/controller/registry/reconciler/reconciler.go:135:7: unknown field 'Handler' in struct literal of type "k8s.io/api/core/v1".Probe
Error: pkg/controller/registry/reconciler/reconciler.go:144:7: unknown field 'Handler' in struct literal of type "k8s.io/api/core/v1".Probe
[...]

Environment

  • operator-lifecycle-manager version: master branch

Additional context
I will have a closer look at it.
Dependencies were bumped in o-f API in this PR: operator-framework/api#212

@fgiloux fgiloux added the kind/bug Categorizes issue or PR as related to a bug. label Jan 19, 2022
@fgiloux
Copy link
Contributor Author

fgiloux commented Jan 19, 2022

Another side effect of the bump is that logr version was updated from 0.4.0 to 1.2.0. This is a major update with breaking changes. Especially logr.Logger is an interface in v0.4.0, renamed to logr.LogSink, and a new type logr.Logger is defined as a struct.

pkg/controller/operators/openshift/options.go:59:11: invalid operation: c.Log == nil (mismatched types logr.Logger and nil)

@dinhxuanvu dinhxuanvu added the triaged Issue has been considered by a member of the OLM community label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triaged Issue has been considered by a member of the OLM community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants