Fix e2e Install Plan creation with permission

Fix #3108

Attempting to delete a CSV that is not in a terminal (e.g. Success) state
fails silently (i.e. the CSV is not deleted). So, wait until the CSV is
in the success state before deleting.

Add logging.

Signed-off-by: Todd Short <todd.short@me.com>

Author: tmshort

test/e2e/installplan_e2e_test.go

@@ -2792,10 +2792,12 @@ var _ = Describe("Install Plan", func() {
 		_, err := fetchCatalogSourceOnStatus(crc, mainCatalogSourceName, generatedNamespace.GetName(), catalogSourceRegistryPodSynced())
 		require.NoError(GinkgoT(), err)
 
+		By("Creating a Subscription")
 		subscriptionName := genName("sub-nginx-")
 		subscriptionCleanup := createSubscriptionForCatalog(crc, generatedNamespace.GetName(), subscriptionName, mainCatalogSourceName, packageName, stableChannel, "", operatorsv1alpha1.ApprovalAutomatic)
 		defer subscriptionCleanup()
 
+		By("Attempt to get Subscription")
 		subscription, err := fetchSubscription(crc, generatedNamespace.GetName(), subscriptionName, subscriptionHasInstallPlanChecker())
 		require.NoError(GinkgoT(), err)
 		require.NotNil(GinkgoT(), subscription)
@@ -2867,6 +2869,10 @@ var _ = Describe("Install Plan", func() {
 		By("Should have removed every matching step")
 		require.Equal(GinkgoT(), 0, len(expectedSteps), "Actual resource steps do not match expected: %#v", expectedSteps)
 
+		By("Waiting on CSV to succeed before deleting")
+		_, err = fetchCSV(crc, generatedNamespace.GetName(), stableCSVName, csvSucceededChecker)
+		require.NoError(GinkgoT(), err)
+
 		GinkgoT().Logf("deleting csv %s/%s", generatedNamespace.GetName(), stableCSVName)
 		By("Explicitly delete the CSV")
 		err = crc.OperatorsV1alpha1().ClusterServiceVersions(generatedNamespace.GetName()).Delete(context.Background(), stableCSVName, metav1.DeleteOptions{})
@@ -2875,14 +2881,24 @@ var _ = Describe("Install Plan", func() {
 			err = nil
 		}
 		require.NoError(GinkgoT(), err)
+		By("Waiting for the CSV to delete")
+		err = waitForCsvToDelete(generatedNamespace.GetName(), stableCSVName, crc)
+		require.NoError(GinkgoT(), err)
 
+		nCrs := 0
+		nCrbs := 0
+		By("Waiting for CRBs and CRs and SAs to delete")
 		Eventually(func() bool {
 			crbs, err := c.KubernetesInterface().RbacV1().ClusterRoleBindings().List(context.Background(), metav1.ListOptions{LabelSelector: fmt.Sprintf("%v=%v", ownerutil.OwnerKey, stableCSVName)})
 			if err != nil {
 				GinkgoT().Logf("error getting crbs: %v", err)
 				return false
 			}
-			if len(crbs.Items) != 0 {
+			if n := len(crbs.Items); n != 0 {
+				if n != nCrbs {
+					GinkgoT().Logf("crbs remaining:  %v", n)
+					nCrbs = n
+				}
 				return false
 			}
 
@@ -2891,7 +2907,11 @@ var _ = Describe("Install Plan", func() {
 				GinkgoT().Logf("error getting crs: %v", err)
 				return false
 			}
-			if len(crs.Items) != 0 {
+			if n := len(crs.Items); n != 0 {
+				if n != nCrs {
+					GinkgoT().Logf("crs remaining: %v", n)
+					nCrs = n
+				}
 				return false
 			}