queueinformer: don't double register informers (#3007)

stevekuznetsov · web-flow · commit 2be5e58b153e · 2023-08-08T11:14:30.000-04:00
The abstraction here doesn't let you re-use an informer without also
causing it to be re-registered and re-started, which is invalid.

Signed-off-by: Steve Kuznetsov &lt;skuznets@redhat.com&gt;
diff --git a/pkg/lib/queueinformer/queueinformer_operator.go b/pkg/lib/queueinformer/queueinformer_operator.go
@@ -141,6 +141,12 @@ func (o *operator) RegisterInformer(informer cache.SharedIndexInformer) error {
 }
 
 func (o *operator) registerInformer(informer cache.SharedIndexInformer) {
+	// never double-register an informer
+	for i := range o.informers {
+		if o.informers[i] == informer {
+			return
+		}
+	}
 	o.informers = append(o.informers, informer)
 	o.addHasSynced(informer.HasSynced)
 }

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,12 @@ func (o *operator) RegisterInformer(informer cache.SharedIndexInformer) error {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`func (o *operator) registerInformer(informer cache.SharedIndexInformer) {`
	`144`	`+ // never double-register an informer`
	`145`	`+ for i := range o.informers {`
	`146`	`+ if o.informers[i] == informer {`
	`147`	`+ return`
	`148`	`+ }`
	`149`	`+ }`
`144`	`150`	`o.informers = append(o.informers, informer)`
`145`	`151`	`o.addHasSynced(informer.HasSynced)`
`146`	`152`	`}`