Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update to catalogd v0.17.0 to share a common certificate issuer #970

Merged
merged 2 commits into from
Jul 3, 2024
Merged

✨ Update to catalogd v0.17.0 to share a common certificate issuer #970

merged 2 commits into from
Jul 3, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 25, 2024 •
edited
Loading

Description

Update to catalogd v0.17.0 to share a common certificate issuer

Fixes: #1000

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit bb53f26
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66858985f7e5e60008817fed
😎 Deploy Preview https://deploy-preview-970--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (ceba614) to head (bb53f26).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files          17       17           
  Lines        1206     1206           
=======================================
  Hits          931      931           
  Misses        193      193           
  Partials       82       82
Flag Coverage Δ
e2e 56.54% <ø> (ø)
unit 51.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort mentioned this pull request Jun 25, 2024
Closed
2 tasks
@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2024

See RFC: Operator-Controller Configuration

@tmshort tmshort mentioned this pull request Jun 27, 2024
Open
27 tasks
joelanford
joelanford previously approved these changes Jun 27, 2024
View reviewed changes
This was referenced Jul 1, 2024
Closed
Closed
@tmshort
Reorganize config to support reusable components
6e1fa6a 
Update to catalogd v0.17.0 to share a common certificate issuer

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort changed the title WIP: Reorganize kustomize config to reduce duplication Update to catalogd v0.17.0 to share a common certificate issuer Jul 3, 2024
@tmshort tmshort changed the title Update to catalogd v0.17.0 to share a common certificate issuer ✨ Update to catalogd v0.17.0 to share a common certificate issuer Jul 3, 2024
@tmshort tmshort marked this pull request as ready for review July 3, 2024 17:07
@tmshort tmshort requested a review from a team as a code owner July 3, 2024 17:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@tmshort
fixup! Reorganize config to support reusable components
bb53f26 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Contributor Author

tmshort commented Jul 3, 2024 •
edited
Loading

Changes since @joelanford's original approval:

  • Include catalogd v0.17.0
  • Rename secure to cert-manager (consistent with catalogd)
  • Move the e2e and cert-manager configs into the overlays directory.
  • Drop the catalogd certificate volume, as catalogd and operator-controller now share a CA

@tmshort tmshort enabled auto-merge July 3, 2024 17:32
@tmshort tmshort added this pull request to the merge queue Jul 3, 2024
Merged via the queue into operator-framework:main with commit dd08e0c Jul 3, 2024
17 checks passed
@tmshort tmshort deleted the kustomize branch July 3, 2024 17:54
@skattoju skattoju mentioned this pull request Jul 5, 2024
Merged
4 tasks
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
@tmshort
✨ Update to catalogd v0.17.0 to share a common certificate issuer (op…
1dd7b89 
…erator-framework#970)

* Reorganize config to support reusable components

Update to catalogd v0.17.0 to share a common certificate issuer

Signed-off-by: Todd Short <tshort@redhat.com>

* fixup! Reorganize config to support reusable components

Signed-off-by: Todd Short <tshort@redhat.com>

---------

Signed-off-by: Todd Short <tshort@redhat.com>
@skattoju skattoju mentioned this pull request Sep 9, 2024
Merged
@skattoju skattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update kustomize configuration in operator-controller
2 participants
@tmshort @joelanford