🐛 fix: extension controller should requeue extensions when catalogs change #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the watch setup of the extension controller where watch events for catalog updates are translated to reconcile requests that bear the name of the catalog, which means it is trying to reconcile an Extension with the same name as the catalog that evented.
This isn't the intention. The intention is to requeue all Extensions when a catalog changes, since that might mean a new/better version is available for us to consume.
Reviewer Checklist