🌱 (fix) remove the testdata COPY from catalogd/testdata/catalogs/test-catalog.Dockerfile to allow the docker build #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
- Coverage 68.37% 68.34% -0.04%
==========================================
Files 63 63
Lines 5117 5117
==========================================
- Hits 3499 3497 -2
- Misses 1389 1390 +1
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Alternatively, for something that doesn’t need to be reverted, simply delete |
…atalog.Dockerfile to allow the docker build
camilamacedo86
force-pushed
the
fix-down
branch
from
c07fb0b to
d961f8d
Compare
camilamacedo86
commented
Feb 18, 2025
| @@ -1,5 +1,4 @@ | |||
| FROM scratch | |||
| COPY test-catalog /configs | |||
There was a problem hiding this comment.
@tmshort that works as well :-P
I was silly. Good point
camilamacedo86
changed the title
Merged
via the queue into
operator-framework:main
with commit Feb 18, 2025
17220c2
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow to pass: openshift/operator-framework-operator-controller#271