🌱 Refactor filter package #1734
Merged
+271
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
+ Coverage 68.24% 68.26% +0.02%
==========================================
Files 58 58
Lines 4988 4995 +7
==========================================
+ Hits 3404 3410 +6
- Misses 1342 1343 +1
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perdasilva
force-pushed
the
fix-filter-and-util-packages
branch
6 times, most recently
from
c7964fe to
2cc81ae
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joelanford
reviewed
Feb 10, 2025
joelanford
reviewed
Feb 10, 2025
azych
reviewed
Feb 10, 2025
perdasilva
force-pushed
the
fix-filter-and-util-packages
branch
4 times, most recently
from
a7cf57d to
d5980c0
Compare
added 4 commits
February 11, 2025 08:13
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
fix-filter-and-util-packages
branch
from
d5980c0 to
5034d99
Compare
azych
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
catalogmetadata/filterpackage by:internal/util/filterFilterfunction toRemoveInPlaceto make it clear that function mutates the inputFilterfunctionFilterandRemoveInPlacetointernal/util/slicesThis was done as slice (and other) filtering is, generally, a useful thing to have and can be used throughout the code-base. I've been using it as part of go'fied rbac rendering tool (
hacks/tools/catalog/generate-manifests) that I made to help me with the single/own namespace testing and RBAC scoping.Reviewer Checklist