Renames NewClient to New to avoid duplication (#422)

m1kola · web-flow · commit cdb99fa0b35b · 2023-09-20T10:33:58.000Z
So we can call `client.New` instead of `client.NewClient`

Signed-off-by: Mikalai Radchuk &lt;mradchuk@redhat.com&gt;
diff --git a/internal/catalogmetadata/client/client.go b/internal/catalogmetadata/client/client.go
@@ -12,7 +12,7 @@ import (
 	"github.com/operator-framework/operator-controller/internal/catalogmetadata"
 )
 
-func NewClient(cl client.Client) *Client {
+func New(cl client.Client) *Client {
 	return &Client{cl: cl}
 }
 
diff --git a/internal/catalogmetadata/client/client_test.go b/internal/catalogmetadata/client/client_test.go
@@ -111,7 +111,7 @@ func TestClient(t *testing.T) {
 				ctx := context.Background()
 				objs, expectedBundles := tt.fakeCatalog()
 
-				fakeCatalogClient := catalogClient.NewClient(
+				fakeCatalogClient := catalogClient.New(
 					fake.NewClientBuilder().WithScheme(scheme).WithObjects(objs...).Build(),
 				)
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import (`
`12`	`12`	`"github.com/operator-framework/operator-controller/internal/catalogmetadata"`
`13`	`13`	`)`
`14`	`14`
`15`		`-func NewClient(cl client.Client) *Client {`
	`15`	`+func New(cl client.Client) *Client {`
`16`	`16`	`return &Client{cl: cl}`
`17`	`17`	`}`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ func TestClient(t *testing.T) {`
`111`	`111`	`ctx := context.Background()`
`112`	`112`	`objs, expectedBundles := tt.fakeCatalog()`
`113`	`113`
`114`		`- fakeCatalogClient := catalogClient.NewClient(`
	`114`	`+ fakeCatalogClient := catalogClient.New(`
`115`	`115`	`fake.NewClientBuilder().WithScheme(scheme).WithObjects(objs...).Build(),`
`116`	`116`	`)`
`117`	`117`