fix: generate proper resource name & finalizer for group-less resources #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
reviewed
Jan 12, 2022
| return getResourceTypeName(getResourceClass()); | ||
| } | ||
|
|
||
| static <T extends HasMetadata> String getResourceTypeName(Class<T> resourceClass) { |
There was a problem hiding this comment.
Same here, pls add unit test.
There was a problem hiding this comment.
This is a workaround for a fix that will be in fabric8 5.12 where it's already pretty well tested.
There was a problem hiding this comment.
Hmm, that is kinda questionable, still our code, maybe we can copy the unit test too?
There was a problem hiding this comment.
But if too much effort, I'm ok to skip it.
csviri
requested changes
Jan 12, 2022
|
|
||
| public static String getDefaultFinalizerName(String crdName) { | ||
| return crdName + FINALIZER_NAME_SUFFIX; | ||
| public static String getDefaultFinalizerName(String resourceName) { |
|
SonarCloud Quality Gate failed. |
csviri
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812